Skip to content

[two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example - #8189

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
Renzo-Olivares:two_dimensional_selection
Jun 2, 2025
Merged

[two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example#8189
auto-submit[bot] merged 9 commits into
flutter:mainfrom
Renzo-Olivares:two_dimensional_selection

Conversation

@Renzo-Olivares

@Renzo-OlivaresRenzo-Olivares commented Nov 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This change adds a SegmentedButton to enable different variations of text selection for the example.

  • Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
  • Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
  • Disabled, disables selection across the entire table.

Text selection in a table is a common use-case that we should showcase.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@Renzo-Olivares
Renzo-Olivaresforce-pushed the two_dimensional_selection branch 2 times, most recently from 91462ab to 43b9327CompareJanuary 13, 2025 20:11
@stuartmorgan-g

stuartmorgan-g commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

From triage: @Renzo-Olivares are you still planning to finish this PR?

@Renzo-Olivares

Renzo-Olivares commented Mar 20, 2025

Copy link
Copy Markdown
ContributorAuthor

I plan on getting back to this soon.

@Piinks

Piinks commented May 20, 2025

Copy link
Copy Markdown
Contributor

Touched base with @Renzo-Olivares, this is still on his radar. 👍

@Renzo-Olivares
Renzo-Olivaresforce-pushed the two_dimensional_selection branch from 43b9327 to 9e82069CompareMay 28, 2025 18:27
@Renzo-Olivares
Renzo-Olivares marked this pull request as ready for review May 28, 2025 19:30
@Renzo-OlivaresRenzo-Olivares changed the title Enable multi-cell/single-cell text selection in Simple Table example[two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table exampleMay 28, 2025
Piinks
Piinks approved these changes Jun 2, 2025
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025
@auto-submit
auto-submitBot merged commit da1d32f into flutter:mainJun 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
da1d32f[two_dimensional_scrollables] Enable multi-cell/single-cell t…
172525c
…ext selection in Simple Table example (flutter/packages#8189)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 3, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
Roll Packages from4463066to1765c95(5 revisions) (#169933)
f61ef2d
flutter/packages@4463066...1765c95
2025-06-03 pawel.jakubowski@leancode.pl [video_player] Platform view
support (flutter/packages#8810)
2025-06-02 kaiquegazola@outlook.com [in_app_purchase_storekit] Add
support to win back offers / promotional offers (flutter/packages#8474)
2025-06-02 rmolivares@renzo-olivares.dev [two_dimensional_scrollables]
Enable multi-cell/single-cell text selection in Simple Table example
(flutter/packages#8189)
2025-05-30 43054281+camsim99@users.noreply.github.com [all_packages]
Bump `compileSdk` version to 35 (flutter/packages#9168)
2025-05-30 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
be698c4 to b25305a (11 revisions) (flutter/packages#9342)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@Renzo-Olivares@FMorschel
[two_dimensional_scrollables] Enable multi-cell/single-cell text sele…
4a9a50d
…ction in Simple Table example (flutter#8189)
This change adds a `SegmentedButton` to enable different variations of text selection for the example.
* Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
* Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
* Disabled, disables selection across the entire table.
Text selection in a table is a common use-case that we should showcase.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@Renzo-Olivares@Ortes
[two_dimensional_scrollables] Enable multi-cell/single-cell text sele…
5390f4a
…ction in Simple Table example (flutter#8189)
This change adds a `SegmentedButton` to enable different variations of text selection for the example.
* Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
* Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
* Disabled, disables selection across the entire table.
Text selection in a table is a common use-case that we should showcase.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Renzo-Olivares
[two_dimensional_scrollables] Enable multi-cell/single-cell text sele…
3adc7c4
…ction in Simple Table example (flutter#8189)
This change adds a `SegmentedButton` to enable different variations of text selection for the example.
* Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
* Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
* Disabled, disables selection across the entire table.
Text selection in a table is a common use-case that we should showcase.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Renzo-Olivares
[two_dimensional_scrollables] Enable multi-cell/single-cell text sele…
dc3749a
…ction in Simple Table example (flutter#8189)
This change adds a `SegmentedButton` to enable different variations of text selection for the example.
* Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
* Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
* Disabled, disables selection across the entire table.
Text selection in a table is a common use-case that we should showcase.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiinksPiinksPiinks approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Renzo-Olivares@stuartmorgan-g@Piinks