Skip to content

[shared_preferences] Fix JSON parsing issue with _decodeValue - #8211

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
Dan-Crane:fix-shared-pref-web-parsing
Feb 18, 2025
Merged

[shared_preferences] Fix JSON parsing issue with _decodeValue#8211
auto-submit[bot] merged 6 commits into
flutter:mainfrom
Dan-Crane:fix-shared-pref-web-parsing

Conversation

@Dan-Crane

@Dan-CraneDan-Crane commented Dec 3, 2024•
edited by stuartmorgan-g
Loading

Copy link
Copy Markdown
Contributor

[shared_preferences] Fix JSON parsing issue with getAllWithParameters

this is a restored PR #5813
Fixesflutter/flutter#156574

Pre-launch Checklist

@Dan-CraneDan-Crane mentioned this pull request Dec 3, 2024
Closed
stuartmorgan-g
stuartmorgan-g requested changes Dec 3, 2024
View reviewed changes
Comment threadpackages/shared_preferences/shared_preferences_web/lib/shared_preferences_web.dart Outdated
Comment threadpackages/shared_preferences/shared_preferences_web/lib/shared_preferences_web.dart Outdated
@Dan-Crane
Dan-Craneforce-pushed the fix-shared-pref-web-parsing branch 2 times, most recently from 17b9578 to daf7473CompareDecember 4, 2024 08:38
@Dan-Crane
Dan-Craneforce-pushed the fix-shared-pref-web-parsing branch from daf7473 to be1e837CompareDecember 5, 2024 04:18
stuartmorgan-g
stuartmorgan-g approved these changes Dec 5, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor fixes, assuming @ditman is happy with it.

Comment thread...preferences/shared_preferences_web/example/integration_test/shared_preferences_web_test.dart Outdated
Comment thread...preferences/shared_preferences_web/example/integration_test/shared_preferences_web_test.dart Outdated
@Dan-Crane
Dan-Craneforce-pushed the fix-shared-pref-web-parsing branch 4 times, most recently from efbb8a4 to 768cdd6CompareDecember 11, 2024 05:11
@Dan-Crane
Dan-Craneforce-pushed the fix-shared-pref-web-parsing branch 2 times, most recently from c544578 to e291e66CompareDecember 26, 2024 09:01
@Dan-Crane

Dan-Crane commented Dec 26, 2024

Copy link
Copy Markdown
ContributorAuthor

@ditman can you please watch this PR when you have time?

@Dan-Crane

Dan-Crane commented Jan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

@ditman hi! Happy new year!:) Can you see the PR, please?

@Dan-Crane
Dan-Craneforce-pushed the fix-shared-pref-web-parsing branch from e291e66 to fb2a65bCompareJanuary 15, 2025 06:07
@Dan-Crane

Dan-Crane commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan Hello!
Can you please help with this PR?

@stuartmorgan-g

stuartmorgan-g commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

@stuartmorgan Hello! Can you please help with this PR?

I'm not sure what you are asking exactly; I've already reviewed it. What help are you looking for from me?

@stuartmorgan-gstuartmorgan-g added the triage-web Should be looked at in web triage label Jan 15, 2025
@Dan-Crane
Dan-Craneforce-pushed the fix-shared-pref-web-parsing branch from fb2a65b to 3a54a90CompareJanuary 27, 2025 11:29
tarrinneal
tarrinneal approved these changes Feb 14, 2025
View reviewed changes

@tarrinnealtarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as is. @stuartmorgan if you'd like to merge it without @ditman taking a look, I'm ok with that as well.

@san-smith

This comment was marked as off-topic.

Sign in to view
@stuartmorgan-g

stuartmorgan-g commented Feb 18, 2025

Copy link
Copy Markdown
Collaborator

I think this is fine as is. @stuartmorgan if you'd like to merge it without @ditman taking a look, I'm ok with that as well.

This is straightforward enough that our reviews are sufficient.

@stuartmorgan-gstuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App and removed triage-web Should be looked at in web triage labels Feb 18, 2025
@auto-submit
auto-submitBot merged commit cb4fb13 into flutter:mainFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
cb4fb13[shared_preferences] Fix JSON parsing issue with _decodeValue (…
a9badda
…flutter/packages#8211)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 18, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
Roll Packages from8542af3tocb4fb13(4 revisions) (#163544)
7e81af2
flutter/packages@8542af3...cb4fb13
2025-02-18 56475207+Dan-Crane@users.noreply.github.com
[shared_preferences] Fix JSON parsing issue with _decodeValue
(flutter/packages#8211)
2025-02-18 pawel.jakubowski@leancode.pl [camera_avfoundation] Migrate
tests to Swift - part 2 (flutter/packages#8613)
2025-02-18 stuartmorgan@google.com [google_sign_in] Adopt task queues
for Android (flutter/packages#8622)
2025-02-17 engine-flutter-autoroll@skia.org Roll Flutter from
892f9c1 to e8f34a9 (71 revisions) (flutter/packages#8614)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@Dan-Crane@androidseb
[shared_preferences] Fix JSON parsing issue with _decodeValue (flutte…
1730363
…r#8211)
[shared_preferences] Fix JSON parsing issue with getAllWithParameters
this is a restored PR flutter#5813Fixesflutter/flutter#156574https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@Dan-Crane@FMorschel
[shared_preferences] Fix JSON parsing issue with _decodeValue (flutte…
7e2b98d
…r#8211)
[shared_preferences] Fix JSON parsing issue with getAllWithParameters
this is a restored PR flutter#5813Fixesflutter/flutter#156574https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Dan-Crane
[shared_preferences] Fix JSON parsing issue with _decodeValue (flutte…
3cbf3f7
…r#8211)
[shared_preferences] Fix JSON parsing issue with getAllWithParameters
this is a restored PR flutter#5813Fixesflutter/flutter#156574https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Dan-Crane
[shared_preferences] Fix JSON parsing issue with _decodeValue (flutte…
c90a2c6
…r#8211)
[shared_preferences] Fix JSON parsing issue with getAllWithParameters
this is a restored PR flutter#5813Fixesflutter/flutter#156574https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@tarrinnealtarrinnealtarrinneal approved these changes
@ditmanditmanAwaiting requested review from ditman

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: shared_preferencesplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[shared_preferences] On Web, exception on initialization when a stored value is not valid JSON

4 participants

@Dan-Crane@stuartmorgan-g@san-smith@tarrinneal