Skip to content

[ci] Cumulative fixes to reopen the tree. - #8344

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ditman:fix-tool-lints
Dec 23, 2024
Merged

[ci] Cumulative fixes to reopen the tree.#8344
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ditman:fix-tool-lints

Conversation

@ditman

Copy link
Copy Markdown
Member

This PR fixes a couple of issues that have popped up in the CI of the tree in the last couple of days:

  1. Disables some Android video_player tests that require network access.
  2. Fixes our internal tool after a breaking change was made in an upstream dependency.

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
ditman requested review from reidbaker and stuartmorgan-g and removed request for tarrinnealDecember 23, 2024 19:32
@ditman
ditman requested a review from camsim99December 23, 2024 19:32
@ditman

Copy link
Copy Markdown
MemberAuthor

(fyi @reidbaker, @stuartmorgan)

@ditman

ditman commented Dec 23, 2024

Copy link
Copy Markdown
MemberAuthor

This needs to be landed on red to fix the current tree failures, but will wait for all pre-submits.

@ditmanditman added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Dec 23, 2024

@camsim99camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this so quickly!

@ditman

ditman commented Dec 23, 2024

Copy link
Copy Markdown
MemberAuthor

A native video_player_avfoundation test failed, but it ran on a canary version of LUCI so it might be a flake. Retrying.

/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m:664: error: -[VideoPlayerTests testAudioOnlyHLSControls] : Asynchronous wait failed: Exceeded timeout of 30 seconds, with unfulfilled expectations: "initialized".
/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m:544: error: -[VideoPlayerTests testAudioOnlyHLSControls] : ((videoInitialization[@"height"]) equal to (@0)) failed: ("(null)") is not equal to ("0")
/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m:545: error: -[VideoPlayerTests testAudioOnlyHLSControls] : ((videoInitialization[@"width"]) equal to (@0)) failed: ("(null)") is not equal to ("0")
/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m:546: error: -[VideoPlayerTests testAudioOnlyHLSControls] : (([videoInitialization[@"duration"] intValue]) equal to (4000) +/- (200)) failed: ("0") is not equal to ("4000") +/- ("200")
Test Case '-[VideoPlayerTests testAudioOnlyHLSControls]' failed (30.119 seconds).

(This was indeed a flake, but now there's integration tests to pass :) )

@ditman

ditman commented Dec 23, 2024

Copy link
Copy Markdown
MemberAuthor
30:19 +0: example works

Narrator: the example did NOT work.

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would also bump the pubspec_parse version in the tool/pubspec.yaml

@ditman

Copy link
Copy Markdown
MemberAuthor

@bparrishMines good call, I'll do it the next time the CI flakes :P

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 23, 2024
@ditman

Copy link
Copy Markdown
MemberAuthor

Looking good, applying autosubmit.

@auto-submit
auto-submitBot merged commit dcf789f into flutter:mainDec 23, 2024
@ditman
ditman deleted the fix-tool-lints branch December 23, 2024 23:25
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Jan 6, 2025
flutter/packages@eb73582...07ae98c
2025-01-06 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8371)
2025-01-05 32538273+ValentinVignal@users.noreply.github.com
[google_maps_flutter] Activate leak testing (flutter/packages#8368)
2025-01-05 32538273+ValentinVignal@users.noreply.github.com
[flutter_markdown] Fix some memory leaks and activate leak testing
[prod-leak-fix] (flutter/packages#8367)
2025-01-03 36674458+WenHaozhan@users.noreply.github.com [image_picker]
Removes use of PHAsset on IOS 14+ (flutter/packages#8190)
2025-01-03 matanlurey@users.noreply.github.com Delete unused templates
`skeleton` and `app_shared` and release as `5.0.0`.
(flutter/packages#8360)
2025-01-02 stuartmorgan@google.com [tool] Ensure that
leak_tracker_flutter_testing is dev-only (flutter/packages#8365)
2025-01-02 stuartmorgan@google.com [pigeon] Discuss stability in README
(flutter/packages#8366)
2025-01-02 tarrinneal@gmail.com [shared_preferences] Add information
about shared preferences android to docs (flutter/packages#8296)
2024-12-30 mchudy@users.noreply.github.com [camera] Remove OCMock from
permission tests (flutter/packages#8350)
2024-12-29 kevmoo@users.noreply.github.com Drop vector bits from
allowed_unpinned_deps.yaml (flutter/packages#8327)
2024-12-28 32538273+ValentinVignal@users.noreply.github.com [camera] Fix
memory leaks in example and activate leak testing
(flutter/packages#8287)
2024-12-27 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds
platform for imports that aren't support on a platform
(flutter/packages#8338)
2024-12-26 jessiewong401@gmail.com Bump Plugin Example Apps to
TargetSdkVersion >= 34 (flutter/packages#8285)
2024-12-26 matanlurey@users.noreply.github.com Re-create
`templates/app`, add deprecation notices for `app_shared` and
`skeleton`. (flutter/packages#8336)
2024-12-26 jessiewong401@gmail.com Update Gradle Command Test to Only
Accept Gradle Declarative Apply (flutter/packages#8325)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.guava:guava from 33.3.1-android to
33.4.0-android in /packages/camera/camera_android_camerax/android
(flutter/packages#8331)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.3.4 to 1.4.1 in
/packages/camera/camera_android_camerax/android (flutter/packages#8330)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump com.google.truth:truth, com.google.code.gson:gson,
com.squareup.okhttp3:okhttp in /packages/espresso/android
(flutter/packages#8089)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[image_picker]: Bump androidx.activity:activity from 1.9.2 to 1.9.3 in
/packages/image_picker/image_picker_android/android
(flutter/packages#7897)
2024-12-23 ditman@gmail.com [ci] Cumulative fixes to reopen the tree.
(flutter/packages#8344)
2024-12-18 magder@google.com Group dependabot updates for some gradle
dependencies (flutter/packages#8100)
2024-12-18 jessiewong401@gmail.com Applied Gradle Plugins Declaratively
All Remaining Example Apps (flutter/packages#8312)
2024-12-18 49699333+dependabot[bot]@users.noreply.github.com
[lifecycle]: Bump androidx.annotation:annotation from 1.7.0 to 1.9.1 in
/packages/flutter_plugin_android_lifecycle/android
(flutter/packages#7974)
2024-12-18 stuartmorgan@google.com [ci] Re-enable macOS sandboxing
(flutter/packages#8293)
2024-12-18 49699333+dependabot[bot]@users.noreply.github.com [espresso]:
Bump com.android.tools.build:gradle from 7.4.1 to 8.7.2 in
/packages/espresso/android (flutter/packages#8013)
2024-12-18 reidbaker@google.com [shared_preferences] Increase minimum
android endorsed version (flutter/packages#8318)
2024-12-17 stuartmorgan@google.com Revert "[shared_preferences] Add
shared preferences devtools" (flutter/packages#8314)
2024-12-16 adson@soraschools.com [shared_preferences] Add shared
preferences devtools (flutter/packages#6749)
2024-12-16 ditman@gmail.com [google_adsense] Add optional init
parameters. (flutter/packages#8297)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
This PR fixes a couple of issues that have popped up in the CI of the tree in the last couple of days:
1. Disables some Android video_player tests that require network access.
2. Fixes our internal tool after a breaking change was made in an upstream dependency.
## Issues
* Mitigates flutter/flutter#160797
* Fixesflutter/flutter#160799
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
This PR fixes a couple of issues that have popped up in the CI of the tree in the last couple of days:
1. Disables some Android video_player tests that require network access.
2. Fixes our internal tool after a breaking change was made in an upstream dependency.
## Issues
* Mitigates flutter/flutter#160797
* Fixesflutter/flutter#160799
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
This PR fixes a couple of issues that have popped up in the CI of the tree in the last couple of days:
1. Disables some Android video_player tests that require network access.
2. Fixes our internal tool after a breaking change was made in an upstream dependency.
## Issues
* Mitigates flutter/flutter#160797
* Fixesflutter/flutter#160799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppemergencyOverride tree-status signal (land even with closed tree), combine with the autosubmit label.p: video_player

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages][tool] Analysis breaking after pubspec_parse change.

4 participants

@ditman@matanlurey@bparrishMines@camsim99