Uh oh!
There was an error while loading. Please reload this page.
Revert "[shared_preferences] update List<String> encode/decode" - #8510
Revert "[shared_preferences] update List<String> encode/decode"#8510camsim99 wants to merge 1 commit into
Conversation
| @@ -1,7 +1,3 @@ | |||
| ## 2.4.3 | |||
There was a problem hiding this comment.
I forget our rules here but I thought we couldnt roll back this version if it was published which the existence of an OOB change implies happened.
There was a problem hiding this comment.
@stuartmorgan please advise. Should we publish a new version?
stuartmorgan-g
commented
Jan 27, 2025
I just realized, I don't think we can revert this. It's been published and may have started converting real-world data to the new form. Updating to a reverted version would lose data. |
stuartmorgan-g
commented
Jan 27, 2025
I'll look at the tests when I'm back at my desk to see if we can easily fix forward; hopefully the tests were just too specific to platform implementations. Otherwise I'll need to think about this more and discuss with @tarrinneal |
Reverts #8335.
This is causing
shared_preferences/shared_preferences/example/integration_test/shared_preferences_test.dart: shared_preferences_async Async throws TypeError when returned getStringList type is incorrectto fail with what looks like an OOB issue and is blocking the tree currently: