Skip to content

[camera_avfoundation] Migrate tests to Swift - part 1 - #8603

Merged
auto-submit[bot] merged 25 commits into
flutter:mainfrom
leancodepl:feature/camera-swift-test-migration
Feb 12, 2025
Merged

[camera_avfoundation] Migrate tests to Swift - part 1#8603
auto-submit[bot] merged 25 commits into
flutter:mainfrom
leancodepl:feature/camera-swift-test-migration

Conversation

@FirentisTFW

@FirentisTFWFirentisTFW commented Feb 11, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR migrates some of Objective-C tests to Swift as a part of Swift migration: flutter/flutter/issues/119109.

I kept the names of test cases the same. I also left most of the implementation comments, although I removed some of them that I considered not very helpful (e.g. "Run test").

Tests migrated in this PR:

  • AvailableCamerasTests
  • CameraExposureTests
  • CameraFocusTests
  • CameraPermissionTests
  • CameraPreviewPauseTests
  • CameraPropertiesTests
  • QueueUtilsTests

Pre-launch Checklist

@FirentisTFW
FirentisTFW marked this pull request as ready for review February 11, 2025 13:58
FirentisTFW
FirentisTFW commented Feb 11, 2025
View reviewed changes
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPermissionTests.swift Outdated
hellohuanlin
hellohuanlin approved these changes Feb 11, 2025
View reviewed changes
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraExposureTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraExposureTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraFocusTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPermissionTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPermissionTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPermissionTests.swift
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPreviewPauseTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/ExceptionCatcher.h
Comment thread...vfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTPermissionServicing.h
@FirentisTFW

FirentisTFW commented Feb 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@hellohuanlin Thanks for the review! I applied all suggestions, please have a look.

hellohuanlin
hellohuanlin approved these changes Feb 12, 2025
View reviewed changes

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellohuanlinhellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@auto-submit
auto-submitBot merged commit c6036d8 into flutter:mainFeb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
c6036d8[camera_avfoundation] Migrate tests to Swift - part 1 (flutte…
828a687
…r/packages#8603)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 17, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
Roll Packages from625023ato8542af3(21 revisions) (#163484)
22c78a0
flutter/packages@625023a...8542af3
2025-02-15 stuartmorgan@google.com [various] Enable `permissive-` for
Windows plugin examples (flutter/packages#8636)
2025-02-15 stuartmorgan@google.com [pigeon] Update task queue handling
(flutter/packages#8627)
2025-02-14 goderbauer@google.com Update CODEOWNERS
(flutter/packages#8628)
2025-02-14 32538273+ValentinVignal@users.noreply.github.com
[flutter_adaptive_scaffold] Fix some memory leaks
(flutter/packages#8546)
2025-02-14 mchudy@users.noreply.github.com [camera] Fix crash when
setting activeFormat on FLTCaptureDevice (flutter/packages#8630)
2025-02-13 mchudy@users.noreply.github.com [camera] Remove remaining
OCMock usage in tests (flutter/packages#8624)
2025-02-13 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Change callback methods with a non-null
return type to non-null (flutter/packages#8564)
2025-02-12 737941+loic-sharma@users.noreply.github.com
[google_sign_in_ios] Adds Swift Package Manager support
(flutter/packages#7356)
2025-02-12 pawel.jakubowski@leancode.pl [camera_avfoundation] Migrate
tests to Swift - part 1 (flutter/packages#8603)
2025-02-12 43054281+camsim99@users.noreply.github.com [video_player]
Re-enables `asset videos live stream duration != 0` test for Android
(flutter/packages#8610)
2025-02-12 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Add support for `TypedStatefulShellBranch`'s
`preload` (flutter/packages#8587)
2025-02-12 magder@google.com [local_auth_darwin] Fix test name for
clarity (flutter/packages#8499)
2025-02-11 ditman@gmail.com [ci] Manually roll master, set -Xmx4G
(flutter/packages#8586)
2025-02-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the gradle-plugin group across 4 directories with 1
update (flutter/packages#8551)
2025-02-10 10687576+bparrishMines@users.noreply.github.com [pigeon] Add
errors for ProxyAPI callback methods and null instances when reading in
a ProxyApiBaseCodec (flutter/packages#8567)
2025-02-10 98884136+berhili098@users.noreply.github.com
[shared_preferences]Fix : SetState returning future
(flutter/packages#8398)
2025-02-10 stuartmorgan@google.com [various] Add deprecation notices to
READMEs (flutter/packages#8598)
2025-02-10 mchudy@users.noreply.github.com [camera] Remove OCMock from
CameraSettingsTests, CameraMethodChannelTests and
CameraSessionPresetsTests (flutter/packages#8592)
2025-02-10 mchudy@users.noreply.github.com [camera] Remove OCMock from
FLTCamPhotoCaptureTests, FLTSavePhotoDelegateTests and StreamingTests
(flutter/packages#8590)
2025-02-07 32538273+ValentinVignal@users.noreply.github.com [go_router]
Add `preload` parameter to `StatefulShellBranchData.$branch`
(flutter/packages#8545)
2025-02-07 pawel.jakubowski@leancode.pl [video_player_avfoundation] iOS
platform view support (flutter/packages#8237)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@FirentisTFW@androidseb
[camera_avfoundation] Migrate tests to Swift - part 1 (flutter#8603)
56980c0
This PR migrates some of Objective-C tests to Swift as a part of Swift migration: [flutter/flutter/issues/119109](flutter/flutter#119109).
I kept the names of test cases the same. I also left most of the implementation comments, although I removed some of them that I considered not very helpful (e.g. "Run test").
Tests migrated in this PR:
- AvailableCamerasTests
- CameraExposureTests
- CameraFocusTests
- CameraPermissionTests
- CameraPreviewPauseTests
- CameraPropertiesTests
- QueueUtilsTests
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@FirentisTFW@FMorschel
[camera_avfoundation] Migrate tests to Swift - part 1 (flutter#8603)
5f9d323
This PR migrates some of Objective-C tests to Swift as a part of Swift migration: [flutter/flutter/issues/119109](flutter/flutter#119109).
I kept the names of test cases the same. I also left most of the implementation comments, although I removed some of them that I considered not very helpful (e.g. "Run test").
Tests migrated in this PR:
- AvailableCamerasTests
- CameraExposureTests
- CameraFocusTests
- CameraPermissionTests
- CameraPreviewPauseTests
- CameraPropertiesTests
- QueueUtilsTests
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@FirentisTFW
[camera_avfoundation] Migrate tests to Swift - part 1 (flutter#8603)
907d5e2
This PR migrates some of Objective-C tests to Swift as a part of Swift migration: [flutter/flutter/issues/119109](flutter/flutter#119109).
I kept the names of test cases the same. I also left most of the implementation comments, although I removed some of them that I considered not very helpful (e.g. "Run test").
Tests migrated in this PR:
- AvailableCamerasTests
- CameraExposureTests
- CameraFocusTests
- CameraPermissionTests
- CameraPreviewPauseTests
- CameraPropertiesTests
- QueueUtilsTests
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@FirentisTFW
[camera_avfoundation] Migrate tests to Swift - part 1 (flutter#8603)
293228f
This PR migrates some of Objective-C tests to Swift as a part of Swift migration: [flutter/flutter/issues/119109](flutter/flutter#119109).
I kept the names of test cases the same. I also left most of the implementation comments, although I removed some of them that I considered not very helpful (e.g. "Run test").
Tests migrated in this PR:
- AvailableCamerasTests
- CameraExposureTests
- CameraFocusTests
- CameraPermissionTests
- CameraPreviewPauseTests
- CameraPropertiesTests
- QueueUtilsTests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlinhellohuanlinhellohuanlin approved these changes
@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-iosplatform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FirentisTFW@stuartmorgan-g@hellohuanlin