[all_packages] Enforce property assignment for compile sdk over method assignment by reidbaker · Pull Request #8897 · flutter/packages

reidbaker · 2025-03-25T17:06:18Z

No issue I just noticed that we were almost consistent in our approach to compileSdk.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] page, which explains my responsibilities.
I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
I signed the [CLA].
The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
I [linked to at least one issue that this PR fixes] in the description above.
I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
I updated/added any relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
All existing and new tests are passing.

stuartmorgan-g

Tool changes LGTM, but I'm still seeing ~40 violations of this locally.

stuartmorgan-g · 2025-03-25T17:08:43Z

+ if (methodAssignmentLine == null) {
+ printError('${indentation}No compileSdk or compileSdkVersion found.');
+ } else {
+ printError('${indentation}No compileSdk = found. Please use property assignment.');


How about No "compileSdk =" found to make this easier to parse if you don't already know what the issue is?

chunhtai

LGTM

reidbaker · 2025-03-25T21:46:22Z

Failures appear unrelated. Hopefully an updated branch will fix the issue.

auto-submit · 2025-03-25T22:06:38Z

autosubmit label was removed for flutter/packages/8897, because - The status or check suite Linux_web web_dart_unit_test_wasm_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

reidbaker · 2025-03-26T18:27:59Z

Blocked on flutter/flutter#165664

ditman · 2025-03-27T03:33:30Z

Clicked "Update branch" because web tests seem to be fixed in master after @stuartmorgan's fix.

auto-submit · 2025-03-27T16:13:52Z

autosubmit label was removed for flutter/packages/8897, because - The status or check suite Mac_arm64 ios_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan-g · 2025-03-28T14:54:27Z

autosubmit label was removed for flutter/packages/8897, because - The status or check suite Mac_arm64 ios_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

I'm seeing this same issue on a roller PR. I'm wondering if it's OOB failure from a maps SDK or server change.

ditman · 2025-03-28T20:27:38Z

Looking at the build history for the suite, it seems this was the first build broken like this was on: 2025-03-25 @ 09:55:

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20ios_platform_tests_shard_2%20master/20650/overview

Associated to this commit:

347d39a (the branch name according to github was "xcode_16_test" 🔮)

stuartmorgan-g · 2025-04-01T14:16:20Z

Once #8967 lands, merging in main should unblock this.

…er method assignment (flutter/packages#8897)

flutter/packages@07496eb...4a36dc6 2025-04-03 1063596+reidbaker@users.noreply.github.com [all_packages] Enforce property assignment for compile sdk over method assignment (flutter/packages#8897) 2025-04-03 stuartmorgan@google.com [google_maps_flutter] Fix iOS info window regression (flutter/packages#8939) 2025-04-02 engine-flutter-autoroll@skia.org Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter/packages#8985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

flutter/packages@07496eb...4a36dc6 2025-04-03 1063596+reidbaker@users.noreply.github.com [all_packages] Enforce property assignment for compile sdk over method assignment (flutter/packages#8897) 2025-04-03 stuartmorgan@google.com [google_maps_flutter] Fix iOS info window regression (flutter/packages#8939) 2025-04-02 engine-flutter-autoroll@skia.org Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter/packages#8985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

flutter/packages@07496eb...4a36dc6 2025-04-03 1063596+reidbaker@users.noreply.github.com [all_packages] Enforce property assignment for compile sdk over method assignment (flutter/packages#8897) 2025-04-03 stuartmorgan@google.com [google_maps_flutter] Fix iOS info window regression (flutter/packages#8939) 2025-04-02 engine-flutter-autoroll@skia.org Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter/packages#8985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

Enforce property assignment for compile sdk over method assignment
a771c27

reidbaker requested review from jesswrd and stuartmorgan-g March 25, 2025 17:06

reidbaker marked this pull request as ready for review March 25, 2025 17:06

stuartmorgan-g reviewed Mar 25, 2025
View reviewed changes

reidbakerand others added 2 commits March 25, 2025 13:46

Formatting and quotes around compile sdk equals
263d5f6

Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
b894db1

jesswrd approved these changes Mar 25, 2025
View reviewed changes

fix all instances of compileSdk using method set
44edef5

reidbaker requested review from Hixie, Piinks, bparrishMines, camsim99, chunhtai, ditman, domesticmouse, gmackall, gspencergoog, matanlurey and tarrinneal as code owners March 25, 2025 18:27

github-actionsBot added p: extension_google_sign_in_as_googleapis_auth p: palette_generator p: pigeon p: flutter_markdown p: flutter_image p: rfw Remote Flutter Widgets p: go_router p: flutter_adaptive_scaffold p: camera p: espresso labels Mar 25, 2025

chunhtai approved these changes Mar 25, 2025
View reviewed changes

Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
ddd8198

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025

Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
87a1d52

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025

matanlurey removed their request for review April 2, 2025 15:30

Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
998eb40

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2025

auto-submitBot merged commit 4a36dc6 into flutter:mainApr 3, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2025
4a36dc6[all_packages] Enforce property assignment for compile sdk ov…
4404e4e
…er method assignment (flutter/packages#8897)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Roll Packages from 07496eb03035 to 4a36dc63f719 (3 revisions) flutter/flutter#166542
Merged

androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
[all_packages] Enforce property assignment for compile sdk over metho…
744acd8
…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
[all_packages] Enforce property assignment for compile sdk over metho…
71d6ba0
…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
[all_packages] Enforce property assignment for compile sdk over metho…
fc2cfd5
…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[all_packages] Enforce property assignment for compile sdk over metho…
27f0762
…d assignment (flutter#8897) No issue I just noticed that we were almost consistent in our approach to compileSdk.

Navigation Menu

Uh oh!

[all_packages] Enforce property assignment for compile sdk over method assignment - #8897

[all_packages] Enforce property assignment for compile sdk over method assignment#8897
auto-submit[bot] merged 9 commits into
flutter:mainfrom
reidbaker:r-2025-03-25-property-assignment-compilesdk

reidbaker commented Mar 25, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-gMar 25, 2025

Uh oh!

reidbakerMar 25, 2025

Uh oh!

chunhtai left a comment

Uh oh!

reidbaker commented Mar 25, 2025

Uh oh!

auto-submitBot commented Mar 25, 2025

Uh oh!

reidbaker commented Mar 26, 2025

Uh oh!

ditman commented Mar 27, 2025

Uh oh!

auto-submitBot commented Mar 27, 2025

Uh oh!

stuartmorgan-g commented Mar 28, 2025

Uh oh!

ditman commented Mar 28, 2025

Uh oh!

stuartmorgan-g commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

reidbaker commented Mar 25, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-gMar 25, 2025

Choose a reason for hiding this comment

Uh oh!

reidbakerMar 25, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Mar 25, 2025

Uh oh!

auto-submitBot commented Mar 25, 2025

Uh oh!

reidbaker commented Mar 26, 2025

Uh oh!

ditman commented Mar 27, 2025

Uh oh!

auto-submitBot commented Mar 27, 2025

Uh oh!

stuartmorgan-g commented Mar 28, 2025

Uh oh!

ditman commented Mar 28, 2025

Uh oh!

stuartmorgan-g commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants