Skip to content

[webview_flutter_android] Adds internal wrapper methods for native WebViewClient. - #8964

Merged
auto-submit[bot] merged 15 commits into
flutter:mainfrom
bparrishMines:webviewclient_methods
Apr 14, 2025
Merged

[webview_flutter_android] Adds internal wrapper methods for native WebViewClient.#8964
auto-submit[bot] merged 15 commits into
flutter:mainfrom
bparrishMines:webviewclient_methods

Conversation

@bparrishMines

@bparrishMinesbparrishMines commented Mar 31, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This adds the SSL classes for #7893 and a few extra WebViewClient methods.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I linked to at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under1.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3

bparrishMines
bparrishMines commented Apr 3, 2025
View reviewed changes
Comment threadpackages/webview_flutter/webview_flutter_android/android/build.gradle
implementation 'androidx.annotation:annotation:1.9.1'
implementation 'androidx.webkit:webkit:1.12.1'
testImplementation 'junit:junit:4.13.2'
testImplementation 'org.mockito:mockito-core:5.16.1'

@bparrishMinesbparrishMinesApr 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required for me to run tests locally. I'm not sure if this is just me or not.

bparrishMines
bparrishMines commented Apr 3, 2025
View reviewed changes
Comment threadpackages/webview_flutter/webview_flutter_android/example/android/app/build.gradle
namespace 'io.flutter.plugins.webviewflutterexample'
compileSdk = flutter.compileSdkVersion

ndkVersion = flutter.ndkVersion

@bparrishMinesbparrishMinesApr 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also required for met to run tests locally.

@bparrishMinesbparrishMines changed the title Webviewclient methods[webview_flutter_android] Adds internal wrapper methods for native WebViewClient.Apr 6, 2025
@bparrishMines
bparrishMines marked this pull request as ready for review April 6, 2025 20:49
@stuartmorgan-g

stuartmorgan-g commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Fixes flutter/flutter#164132 by passing a TestInstanceManager when needed.

Wrong issue link? That one is about camera.

stuartmorgan-g
stuartmorgan-g approved these changes Apr 10, 2025
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments

Comment thread...utter_android/android/src/main/java/io/flutter/plugins/webviewflutter/ProxyApiRegistrar.java Outdated
Comment threadpackages/webview_flutter/webview_flutter_android/pigeons/android_webkit.dart
Comment threadpackages/webview_flutter/webview_flutter_android/pigeons/android_webkit.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_android/pigeons/android_webkit.dart
WebView webView,
FileChooserParams params,
)? onShowFileChooser;
) onShowFileChooser;

@stuartmorgan-gstuartmorgan-gApr 10, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to non-nullable on these callbacks?

@bparrishMinesbparrishMinesApr 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was caused by #8567. They are already implemented in the AndroidWebViewController: https://github.com/flutter/packages/blob/main/packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart#L187. The method just wasn't required on the Dart side.

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2025
@auto-submit
auto-submitBot merged commit 4389067 into flutter:mainApr 14, 2025
@bparrishMines
bparrishMines deleted the webviewclient_methods branch April 14, 2025 18:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
4389067[webview_flutter_android] Adds internal wrapper methods for n…
f9ebe09
…ative `WebViewClient`. (flutter/packages#8964)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
4389067[webview_flutter_android] Adds internal wrapper methods for n…
3f7214d
…ative `WebViewClient`. (flutter/packages#8964)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
4389067[webview_flutter_android] Adds internal wrapper methods for n…
4303264
…ative `WebViewClient`. (flutter/packages#8964)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 15, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
Roll Packages fromf26b681to2fcc403(4 revisions) (#167218)
2a6968a
flutter/packages@f26b681...2fcc403
2025-04-15 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Updates internal API wrapper to use ProxyApis
(flutter/packages#8618)
2025-04-14 stuartmorgan@google.com [tool] Run a config-only build before
Xcode analyze (flutter/packages#9075)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds internal wrapper methods for native
`WebViewClient`. (flutter/packages#8964)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and
updates native wrapper for `SecTrust` and `SecCertificate`
(flutter/packages#9016)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
Roll Packages fromf26b681to2fcc403(4 revisions) (#167218)
1f43707
flutter/packages@f26b681...2fcc403
2025-04-15 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Updates internal API wrapper to use ProxyApis
(flutter/packages#8618)
2025-04-14 stuartmorgan@google.com [tool] Run a config-only build before
Xcode analyze (flutter/packages#9075)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds internal wrapper methods for native
`WebViewClient`. (flutter/packages#8964)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and
updates native wrapper for `SecTrust` and `SecCertificate`
(flutter/packages#9016)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll@mboetger
Roll Packages fromf26b681to2fcc403(4 revisions) (flutter#167218)
4dd589c
flutter/packages@f26b681...2fcc403
2025-04-15 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Updates internal API wrapper to use ProxyApis
(flutter/packages#8618)
2025-04-14 stuartmorgan@google.com [tool] Run a config-only build before
Xcode analyze (flutter/packages#9075)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds internal wrapper methods for native
`WebViewClient`. (flutter/packages#8964)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and
updates native wrapper for `SecTrust` and `SecCertificate`
(flutter/packages#9016)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ash2moon pushed a commit to ash2moon/flutter that referenced this pull request Apr 21, 2025
@engine-flutter-autoroll@ash2moon
Roll Packages fromf26b681to2fcc403(4 revisions) (flutter#167218)
b55de56
flutter/packages@f26b681...2fcc403
2025-04-15 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Updates internal API wrapper to use ProxyApis
(flutter/packages#8618)
2025-04-14 stuartmorgan@google.com [tool] Run a config-only build before
Xcode analyze (flutter/packages#9075)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds internal wrapper methods for native
`WebViewClient`. (flutter/packages#8964)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and
updates native wrapper for `SecTrust` and `SecCertificate`
(flutter/packages#9016)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@bparrishMines@nick-llewellyn
[webview_flutter_android] Adds internal wrapper methods for native `W…
7d14f46
…ebViewClient`. (flutter#8964)
This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@bparrishMines@androidseb
[webview_flutter_android] Adds internal wrapper methods for native `W…
41739b3
…ebViewClient`. (flutter#8964)
This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@bparrishMines@FMorschel
[webview_flutter_android] Adds internal wrapper methods for native `W…
577a7c7
…ebViewClient`. (flutter#8964)
This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@bparrishMines@Ortes
[webview_flutter_android] Adds internal wrapper methods for native `W…
6b552a4
…ebViewClient`. (flutter#8964)
This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll@romanejaquez
Roll Packages fromf26b681to2fcc403(4 revisions) (flutter#167218)
f3338c1
flutter/packages@f26b681...2fcc403
2025-04-15 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Updates internal API wrapper to use ProxyApis
(flutter/packages#8618)
2025-04-14 stuartmorgan@google.com [tool] Run a config-only build before
Xcode analyze (flutter/packages#9075)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Adds internal wrapper methods for native
`WebViewClient`. (flutter/packages#8964)
2025-04-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and
updates native wrapper for `SecTrust` and `SecCertificate`
(flutter/packages#9016)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@bparrishMines
[webview_flutter_android] Adds internal wrapper methods for native `W…
568da20
…ebViewClient`. (flutter#8964)
This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@bparrishMines
[webview_flutter_android] Adds internal wrapper methods for native `W…
6dd0f3e
…ebViewClient`. (flutter#8964)
This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: webview_flutterplatform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bparrishMines@stuartmorgan-g