Skip to content

[camera_avfoundation] Implementation swift migration - part 2 - #9007

Merged
auto-submit[bot] merged 12 commits into
flutter:mainfrom
leancodepl:feature/camera-implementation-swift-migration-part2
May 1, 2025
Merged

[camera_avfoundation] Implementation swift migration - part 2#9007
auto-submit[bot] merged 12 commits into
flutter:mainfrom
leancodepl:feature/camera-implementation-swift-migration-part2

Conversation

@RobertOdrowaz

@RobertOdrowazRobertOdrowaz commented Apr 5, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Migrates camera implementation as part of flutter/flutter#119109

This PR migrates CameraPlugin class.

While it wasn't the goal of this PR it partially resolves the issue regarding switching the camera during recording. The main problem there was that the capture device wasn't actually changed because the camera name passed to the FLTCam.setDescriptionWhileRecording wasn't used and instead a captureDeviceFactory was called which returned a capture device with the same name as during the initial set up. In this pr "named" capture device factory is propagated to FLTCam allowing passing the new capture device name during in setDescriptionWhileRecording.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3

@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part2 branch 3 times, most recently from aa4269d to 8be6136CompareApril 16, 2025 10:43
@RobertOdrowaz
RobertOdrowaz marked this pull request as ready for review April 16, 2025 11:26
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part2 branch from 8be6136 to 859ad13CompareApril 16, 2025 11:32
hellohuanlin
hellohuanlin reviewed Apr 22, 2025
View reviewed changes

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a complete review, left a few questions

Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part2 branch from 859ad13 to 63292b4CompareApril 23, 2025 07:03
hellohuanlin
hellohuanlin reviewed Apr 29, 2025
View reviewed changes
Comment thread...amera_avfoundation/example/ios/RunnerTests/CameraCaptureSessionQueueRaceConditionTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraOrientationTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraOrientationTests.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
Comment thread...a/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.swift Outdated
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part2 branch from 63292b4 to 2898d01CompareApril 30, 2025 06:43
@RobertOdrowazRobertOdrowaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@auto-submit
auto-submitBot merged commit 250ee0d into flutter:mainMay 1, 2025
@RobertOdrowazRobertOdrowaz mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2025
@engine-flutter-autoroll
250ee0d[camera_avfoundation] Implementation swift migration - part 2 (…
38d15ee
…flutter/packages#9007)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 1, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request May 1, 2025
@engine-flutter-autoroll
Roll Packages from8d01cd9to250ee0d(1 revision) (#168148)
e1a7daf
flutter/packages@8d01cd9...250ee0d
2025-05-01 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 2 (flutter/packages#9007)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@RobertOdrowaz@androidseb
[camera_avfoundation] Implementation swift migration - part 2 (flutte…
50bd0d1
…r#9007)
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates `CameraPlugin` class.
While it wasn't the goal of this PR it partially resolves the [issue](flutter/flutter#162376) regarding switching the camera during recording. The main problem there was that the capture device wasn't actually changed because the camera name passed to the `FLTCam.setDescriptionWhileRecording` wasn't used and instead a `captureDeviceFactory` was called which returned a capture device with the same name as during the initial set up. In this pr "named" capture device factory is propagated to `FLTCam` allowing passing the new capture device name during in `setDescriptionWhileRecording`.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@RobertOdrowaz@FMorschel
[camera_avfoundation] Implementation swift migration - part 2 (flutte…
792cba0
…r#9007)
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates `CameraPlugin` class.
While it wasn't the goal of this PR it partially resolves the [issue](flutter/flutter#162376) regarding switching the camera during recording. The main problem there was that the capture device wasn't actually changed because the camera name passed to the `FLTCam.setDescriptionWhileRecording` wasn't used and instead a `captureDeviceFactory` was called which returned a capture device with the same name as during the initial set up. In this pr "named" capture device factory is propagated to `FLTCam` allowing passing the new capture device name during in `setDescriptionWhileRecording`.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@RobertOdrowaz@Ortes
[camera_avfoundation] Implementation swift migration - part 2 (flutte…
deb4103
…r#9007)
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates `CameraPlugin` class.
While it wasn't the goal of this PR it partially resolves the [issue](flutter/flutter#162376) regarding switching the camera during recording. The main problem there was that the capture device wasn't actually changed because the camera name passed to the `FLTCam.setDescriptionWhileRecording` wasn't used and instead a `captureDeviceFactory` was called which returned a capture device with the same name as during the initial set up. In this pr "named" capture device factory is propagated to `FLTCam` allowing passing the new capture device name during in `setDescriptionWhileRecording`.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@RobertOdrowaz
[camera_avfoundation] Implementation swift migration - part 2 (flutte…
b5b0834
…r#9007)
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates `CameraPlugin` class.
While it wasn't the goal of this PR it partially resolves the [issue](flutter/flutter#162376) regarding switching the camera during recording. The main problem there was that the capture device wasn't actually changed because the camera name passed to the `FLTCam.setDescriptionWhileRecording` wasn't used and instead a `captureDeviceFactory` was called which returned a capture device with the same name as during the initial set up. In this pr "named" capture device factory is propagated to `FLTCam` allowing passing the new capture device name during in `setDescriptionWhileRecording`.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@RobertOdrowaz
[camera_avfoundation] Implementation swift migration - part 2 (flutte…
9fd7c31
…r#9007)
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates `CameraPlugin` class.
While it wasn't the goal of this PR it partially resolves the [issue](flutter/flutter#162376) regarding switching the camera during recording. The main problem there was that the capture device wasn't actually changed because the camera name passed to the `FLTCam.setDescriptionWhileRecording` wasn't used and instead a `captureDeviceFactory` was called which returned a capture device with the same name as during the initial set up. In this pr "named" capture device factory is propagated to `FLTCam` allowing passing the new capture device name during in `setDescriptionWhileRecording`.
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlinhellohuanlinhellohuanlin approved these changes
@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g
@vashworthvashworthAwaiting requested review from vashworth

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-iosplatform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RobertOdrowaz@hellohuanlin