Uh oh!
There was an error while loading. Please reload this page.
[interactive_media_ads] Adds support for companion ads - #9260
Merged
Conversation
bparrishMines
marked this pull request as ready for review
June 3, 2025 18:03
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| /// The height of the companion slot. | ||
| /// | ||
| /// Returns `null` when [isFluid] returns true; |
Collaborator
There was a problem hiding this comment.
Having this be comment-enforced rather than type-enforced isn't ideal; all the uses of these end up doing force-unwraps. What about using a sealed class called something like CompanionAdSize, with subclasses CompanionAdSizeFixed and ...Fluid, where the former has non-nullable width and height fields, and the latter is empty? Then this class can have a non-nullable size (instead of width, height, and isFluid), and usage will get full type safety as to whether or not there is a width and height.
ContributorAuthor
There was a problem hiding this comment.
Good suggestion. I added the lib/src/platform_interface/ad_companion_ad_slot_size.dart file with the sealed classes.
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2025
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 12, 2025
flutter/packages@0b322a2...6d3aaf4 2025-06-11 stuartmorgan@google.com Roll Flutter master to 824868f (flutter/packages#9416) 2025-06-11 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for companion ads (flutter/packages#9260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Fixesflutter/flutter#153446 Adds `CompanionAdSlot` and `AdDisplayContainer(companionAds)`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@0b322a2...6d3aaf4 2025-06-11 stuartmorgan@google.com Roll Flutter master to 824868f (flutter/packages#9416) 2025-06-11 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for companion ads (flutter/packages#9260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Fixesflutter/flutter#153446 Adds `CompanionAdSlot` and `AdDisplayContainer(companionAds)`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Fixesflutter/flutter#153446 Adds `CompanionAdSlot` and `AdDisplayContainer(companionAds)`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
Fixesflutter/flutter#153446 Adds `CompanionAdSlot` and `AdDisplayContainer(companionAds)`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesflutter/flutter#153446
Adds
CompanionAdSlotandAdDisplayContainer(companionAds).Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3