Uh oh!
There was an error while loading. Please reload this page.
[go_router] Use library prefix for meta - #9434
Merged
auto-submit[bot] merged 1 commit intoJun 18, 2025
Merged
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
9 tasks
chunhtai
approved these changes
Jun 13, 2025
chunhtai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will there be another migration to use the foundation one?
loic-sharma
commented
Jun 13, 2025
MemberAuthor
Yup! |
stuartmorgan-g
commented
Jun 17, 2025
Collaborator
test-exempt: code refactor with no semantic change |
loic-sharmaforce-pushed
the
go_router_prepare_for_internal
branch
from
June 17, 2025 16:48
f5b65f8 to
99bd076Compareengine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2025
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 19, 2025
flutter/packages@715a0a5...0ec4053 2025-06-19 engine-flutter-autoroll@skia.org Roll Flutter from 8303a96 to 85a9b4f (93 revisions) (flutter/packages#9457) 2025-06-19 32538273+ValentinVignal@users.noreply.github.com [go_router] Update sype safe routing topic to use mixin from go_router_builder 3.0.0 (flutter/packages#9422) 2025-06-19 august.oberhauser@swissinfo.ch [go_router] fix: PopScope.onPopInvokedWithResult not called in branch routes (flutter/packages#9245) 2025-06-18 10687576+bparrishMines@users.noreply.github.com [pigeon] Create a message call free InstanceManager when running unit tests (flutter/packages#9395) 2025-06-18 737941+loic-sharma@users.noreply.github.com [go_router] Use library prefix for meta (flutter/packages#9434) 2025-06-18 41765610+ahyangnb@users.noreply.github.com [go_router] fix Popping state and re-rendering scaffold at the same time doesn't update the URL on web [new] (flutter/packages#8352) 2025-06-18 robert.odrowaz@leancode.pl [camera_avfoundation] Fix incorrect types in image stream events (flutter/packages#9418) 2025-06-18 stuartmorgan@google.com [go_router_builder] Temporarily restrict `build` (flutter/packages#9453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
We plan to export the `internal` attribute from `package:flutter/foundation.dart`. Currently, `go_router` has files that import both `package:meta/meta.dart` and `package:flutter/foundation.dart`. This causes [lint failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712222978061136193/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/stdout) when `foundation` exports `internal`: ``` info - lib/src/match.dart:12:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import info - lib/src/route.dart:10:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import ``` This updates go_router to use a library prefix for `package:meta` in affected files to make the lints happy. This change is a refactoring and does not affect semantics and is exempt from the test, version change, and CHANGELOG policies. Part of flutter/flutter#167668 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@715a0a5...0ec4053 2025-06-19 engine-flutter-autoroll@skia.org Roll Flutter from 8303a96 to 85a9b4f (93 revisions) (flutter/packages#9457) 2025-06-19 32538273+ValentinVignal@users.noreply.github.com [go_router] Update sype safe routing topic to use mixin from go_router_builder 3.0.0 (flutter/packages#9422) 2025-06-19 august.oberhauser@swissinfo.ch [go_router] fix: PopScope.onPopInvokedWithResult not called in branch routes (flutter/packages#9245) 2025-06-18 10687576+bparrishMines@users.noreply.github.com [pigeon] Create a message call free InstanceManager when running unit tests (flutter/packages#9395) 2025-06-18 737941+loic-sharma@users.noreply.github.com [go_router] Use library prefix for meta (flutter/packages#9434) 2025-06-18 41765610+ahyangnb@users.noreply.github.com [go_router] fix Popping state and re-rendering scaffold at the same time doesn't update the URL on web [new] (flutter/packages#8352) 2025-06-18 robert.odrowaz@leancode.pl [camera_avfoundation] Fix incorrect types in image stream events (flutter/packages#9418) 2025-06-18 stuartmorgan@google.com [go_router_builder] Temporarily restrict `build` (flutter/packages#9453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
We plan to export the `internal` attribute from `package:flutter/foundation.dart`. Currently, `go_router` has files that import both `package:meta/meta.dart` and `package:flutter/foundation.dart`. This causes [lint failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712222978061136193/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/stdout) when `foundation` exports `internal`: ``` info - lib/src/match.dart:12:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import info - lib/src/route.dart:10:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import ``` This updates go_router to use a library prefix for `package:meta` in affected files to make the lints happy. This change is a refactoring and does not affect semantics and is exempt from the test, version change, and CHANGELOG policies. Part of flutter/flutter#167668 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
We plan to export the `internal` attribute from `package:flutter/foundation.dart`. Currently, `go_router` has files that import both `package:meta/meta.dart` and `package:flutter/foundation.dart`. This causes [lint failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712222978061136193/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/stdout) when `foundation` exports `internal`: ``` info - lib/src/match.dart:12:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import info - lib/src/route.dart:10:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import ``` This updates go_router to use a library prefix for `package:meta` in affected files to make the lints happy. This change is a refactoring and does not affect semantics and is exempt from the test, version change, and CHANGELOG policies. Part of flutter/flutter#167668 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
We plan to export the `internal` attribute from `package:flutter/foundation.dart`. Currently, `go_router` has files that import both `package:meta/meta.dart` and `package:flutter/foundation.dart`. This causes [lint failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712222978061136193/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/stdout) when `foundation` exports `internal`: ``` info - lib/src/match.dart:12:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import info - lib/src/route.dart:10:8 - The import of 'package:meta/meta.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/foundation.dart'. Try removing the import directive. - unnecessary_import ``` This updates go_router to use a library prefix for `package:meta` in affected files to make the lints happy. This change is a refactoring and does not affect semantics and is exempt from the test, version change, and CHANGELOG policies. Part of flutter/flutter#167668 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We plan to export the
internalattribute frompackage:flutter/foundation.dart.Currently,
go_routerhas files that import bothpackage:meta/meta.dartandpackage:flutter/foundation.dart. This causes lint failures whenfoundationexportsinternal:This updates go_router to use a library prefix for
package:metain affected files to make the lints happy.This change is a refactoring and does not affect semantics and is exempt from the test, version change, and CHANGELOG policies.
Part of flutter/flutter#167668
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3