Uh oh!
There was an error while loading. Please reload this page.
[webview_flutter_platform_interface] Provide flexible API for loading local HTML files - #9697
Merged
auto-submit[bot] merged 1 commit intoAug 1, 2025
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new, more flexible API for loading local HTML files by adding a LoadFileParams class and a loadFileWithParams method to PlatformWebViewController. The changes include updates to the platform interface, new tests for the added functionality, and corresponding documentation and version updates. My review focuses on improving documentation clarity and consistency. Overall, the changes are well-implemented and tested.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
11 tasks
agavrilkoforce-pushed
the
feature/#136479_webview_flutter_platform_interface
branch
from
July 30, 2025 00:35
1d4903e to
59be663ComparebparrishMines
approved these changes
Jul 31, 2025
bparrishMines
left a comment
Contributor
There was a problem hiding this comment.
LGTM with change to make class base
| /// } | ||
| /// ``` | ||
| @immutable | ||
| class LoadFileParams { |
Contributor
There was a problem hiding this comment.
nit: This can be made into a base class to ensure it is extended.
Suggested change
| classLoadFileParams { | |
| baseclassLoadFileParams { |
flutter/flutter#136479 • Added LoadFileParams to specify parameters for loading local HTML pages. • PlatformWebViewController class extended with the new method loadFileWithParams(LoadFileParams).
agavrilkoforce-pushed
the
feature/#136479_webview_flutter_platform_interface
branch
from
July 31, 2025 20:33
59be663 to
8adf1daCompareUh oh!
There was an error while loading. Please reload this page.
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2025
… loading local HTML files (flutter/packages#9697)
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
agavrilko
deleted the
feature/#136479_webview_flutter_platform_interface
branch
August 5, 2025 21:26
danilozhang pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220 pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 stuartmorgan@google.com Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 engine-flutter-autoroll@skia.org Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 gavrilko.alexander@gmail.com [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 jessiewong401@gmail.com Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
… local HTML files (flutter#9697) [https://github.com/flutter/flutter/issues/136479](https://github.com/flutter/flutter/issues/136479) These are the platform interface changes, after the main PR was approved. [https://github.com/flutter/packages/pull/8787](https://github.com/flutter/packages/pull/8787) What was changed: * Added `LoadFileParams` to specify parameters for loading local HTML pages. * `PlatformWebViewController` class extended with the new method `loadFileWithParams(LoadFileParams)`. * Unit tests for the new functionality of the `PlatformWebViewController` were added. ## Pre-Review Checklist
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
… local HTML files (flutter#9697) [https://github.com/flutter/flutter/issues/136479](https://github.com/flutter/flutter/issues/136479) These are the platform interface changes, after the main PR was approved. [https://github.com/flutter/packages/pull/8787](https://github.com/flutter/packages/pull/8787) What was changed: * Added `LoadFileParams` to specify parameters for loading local HTML pages. * `PlatformWebViewController` class extended with the new method `loadFileWithParams(LoadFileParams)`. * Unit tests for the new functionality of the `PlatformWebViewController` were added. ## Pre-Review Checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/flutter#136479
These are the platform interface changes, after the main PR was approved.
#8787
What was changed:
LoadFileParamsto specify parameters for loading local HTML pages.PlatformWebViewControllerclass extended with the new methodloadFileWithParams(LoadFileParams).PlatformWebViewControllerwere added.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].///).