Uh oh!
There was an error while loading. Please reload this page.
[interactive_media_ads] Fixes setting adsresponse on Android - #9744
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the Android implementation where setAdTagUrl was being called incorrectly for an adsResponse. The fix correctly calls setAdsResponse and is supported by a new test case, version bumps, and a changelog update. The changes look good overall.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bparrishMines
marked this pull request as ready for review
August 4, 2025 18:32
stuartmorgan-g
approved these changes
Aug 4, 2025
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Sorry I missed this; I try to look for this kind of copypasta in the reviews of the wrappers, but it can be hard to see.
bparrishMines
commented
Aug 4, 2025
ContributorAuthor
No problem! I should have noticed this before I merged the last changes. I'm still getting accustomed to starting with AI generated code rather than writing code from scratch. |
Uh oh!
There was an error while loading. Please reload this page.
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2025
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 NearTox@outlook.com [go_router] add initial json support #110781 (flutter/packages#9404) 2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721) 2025-08-04 magder@google.com [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danilozhang pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 NearTox@outlook.com [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721) 2025-08-04 magder@google.com [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 NearTox@outlook.com [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721) 2025-08-04 magder@google.com [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 NearTox@outlook.com [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721) 2025-08-04 magder@google.com [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220 pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 NearTox@outlook.com [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721) 2025-08-04 magder@google.com [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 NearTox@outlook.com [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 magder@google.com Update CODEOWNERS (flutter/packages#9721) 2025-08-04 magder@google.com [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 engine-flutter-autoroll@skia.org Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…#9744) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…#9744) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3