Skip to content

[go_router] improve coverage - #977

Merged
fluttergithubbot merged 32 commits into
flutter:mainfrom
Ascenio:main
Mar 21, 2022
Merged

[go_router] improve coverage#977
fluttergithubbot merged 32 commits into
flutter:mainfrom
Ascenio:main

Conversation

@Ascenio

@AscenioAscenio commented Feb 28, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor
BeforeAfter

This PR adds new tests, reaching code paths not previously covered as pointed by a coverage report.
Closes#99286

No CHANGELOG change: because it doesn't affect the package's users.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

maheshj01
maheshj01 reviewed Mar 1, 2022
View reviewed changes
Comment threadpackages/go_router/test/src/custom_transition_page_test.dart Outdated
chunhtai
chunhtai reviewed Mar 1, 2022
View reviewed changes
Comment threadpackages/go_router/test/go_router_test.dart Outdated
Comment threadpackages/go_router/test/go_router_test.dart Outdated
Comment threadpackages/go_router/test/src/custom_transition_page_test.dart Outdated
Comment threadpackages/go_router/test/src/go_router_cupertino_test.dart Outdated
Comment threadpackages/go_router/test/src/go_router_delegate_test.dart Outdated
Comment threadpackages/go_router/test/src/go_router_material_test.dart Outdated
Comment threadpackages/go_router/test/src/go_router_test.dart Outdated
@chunhtai

chunhtai commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Also I have a massive lint update to the package #1017

I would prefer to land it before this pr to avoid adding more tech debt on top of go_router

Ascenioand others added 19 commits March 6, 2022 20:49
@Ascenio
test: adds GoRouterHelper tests
c185e4b
@Ascenio
test: adds InheritedGoRouter tests
4c5d57b
@Ascenio
test: adds cupertino related tests
2b9b1ad
@Ascenio
fix: switches from backticks to square brackets
27be0f0
Because vscode test runner doesn't like it. xD
@Ascenio
test: adds material related tests
fb08dc9
@Ascenio
test: adds GoRouterErrorScreen tests
1c4a1e4
@Ascenio
test: adds transitions related tests
5543ace
@Ascenio
test: adds GoRouterDelegate tests
7a658f9
@Ascenio
test: adds GoRouter tests
03c7a08
@Ascenio
test: adds GoRoute tests
031a3bb
@Ascenio
test: adds more transitions related tests
a8811d4
@Ascenio
docs: updates changelog
8de564b
@Ascenio
refactor: moves the tests to correct folder
4cf6986
@Ascenio
chore: adds license header to tests
f6dacbf
@Ascenio@chunhtai
fix: asserts on expected values of GoRouterTest
0775847
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
@Ascenio
refactor: renames extensions' tests
fbe702b
@Ascenio
refactor: merges GoRouter related tests
369a8b8
@Ascenio
chore: applies latest lint changes
cffa96c
@Ascenio
refactor: tests NoTransitionPage based on widget's position
f87f52e
@Ascenio
Ascenio requested a review from chunhtaiMarch 7, 2022 02:29
@Ascenio
Ascenio requested a review from maheshj01March 8, 2022 12:23
chunhtai
chunhtai reviewed Mar 8, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Can you remove the src sub folder? Let's follow the folder structure of other packages. The folder test/ maps to lib/src directly, so you don't need to create a src fold in test folder.

Comment threadpackages/go_router/CHANGELOG.md
chunhtai
chunhtai reviewed Mar 9, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests seemed to be gone?

chunhtai
chunhtai approved these changes Mar 10, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ascenio

Ascenio commented Mar 10, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Some tests seemed to be gone?

Technical Difficulties 🤣

@chunhtai

chunhtai commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

@Ascenio it looks like there is a conflict?

@chunhtai

chunhtai commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

the build fails

�[36m[0:00] Running for go_router...�[0m
3.0.4 -> 3.0.5
�[31m When bumping the version for release, the NEXT section should be incorporated into the new version's release notes.�[0m

johnpryan
johnpryan requested changes Mar 19, 2022
View reviewed changes
Comment threadpackages/go_router/test/go_router_test.dart Outdated
Comment threadpackages/go_router/test/go_route_test.dart
Comment threadpackages/go_router/test/go_router_delegate_test.dart
Comment threadpackages/go_router/test/go_router_delegate_test.dart Outdated
Comment threadpackages/go_router/test/go_router_error_page_test.dart Outdated
Comment threadpackages/go_router/test/inherited_go_router_test.dart Outdated
@johnpryan

johnpryan commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

I think most of my comments can be addressed as a follow-up. I can file issues if they're out of scope for this PR.

@fluttergithubbot
fluttergithubbot merged commit a9d6bf1 into flutter:mainMar 21, 2022
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Ascenio
[go_router] improve coverage (flutter#977)
5bb3dbb
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Ascenio
[go_router] improve coverage (flutter#977)
0e005ba
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryanjohnpryanjohnpryan approved these changes
@chunhtaichunhtaichunhtai approved these changes
@maheshj01maheshj01Awaiting requested review from maheshj01
@Renzo-OlivaresRenzo-OlivaresAwaiting requested review from Renzo-Olivares
@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

waiting for tree to go green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router] Increase coverage

5 participants

@Ascenio@chunhtai@johnpryan@maheshj01@fluttergithubbot