Skip to content

[google_fonts] Improve CONTRIBUTING and generator README - #9917

Merged
auto-submit[bot] merged 6 commits into
mainfrom
google-fonts-improvements
Sep 4, 2025
Merged

[google_fonts] Improve CONTRIBUTING and generator README#9917
auto-submit[bot] merged 6 commits into
mainfrom
google-fonts-improvements

Conversation

@guidezpl

@guidezplguidezpl commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Apply feedback from #9895

Note: the families_diff file created by the generator should suffice in writing CHANGELOG updates

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2↩3

@guidezpl
guidezpl requested a review from Piinks as a code ownerAugust 28, 2025 07:27
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 28, 2025
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates and improves the documentation for the google_fonts package generator. It achieves this by removing the package-level CONTRIBUTING.md and moving its contents into an expanded generator/README.md. The changes make the instructions for running the generator clearer and more discoverable. I've provided a couple of suggestions to further improve the wording and fix a broken link in the new README file.

Comment threadpackages/google_fonts/generator/README.md Outdated
Comment threadpackages/google_fonts/generator/README.md Outdated
guidezpland others added 2 commits August 28, 2025 09:42
@guidezpl@gemini-code-assist
Clarity
fd80e8c
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@guidezpl@gemini-code-assist
Fix link
2396313
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@guidezpl

guidezpl commented Aug 28, 2025

Copy link
Copy Markdown
MemberAuthor

exempted from CHANGELOG update and version change: local development

@guidezplguidezpl added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 28, 2025
stuartmorgan-g
stuartmorgan-g reviewed Aug 28, 2025
View reviewed changes
Comment threadpackages/google_fonts/generator/README.md Outdated
@guidezplguidezpl changed the title [google_fonts] Consolidate and improve generator README[google_fonts] Improve CONTRIBUTING and generator READMEAug 28, 2025
Piinks
Piinks reviewed Aug 28, 2025
View reviewed changes
Comment threadpackages/google_fonts/generator/README.md Outdated
regenerate most Dart code (e.g. `GoogleFonts` class), and [families_supported](./families_supported).

1. Navigate to the root directory of this project.
Note: Googlers only, pending b/280786655, there is an additional prerequisite step required of the Google Fonts team

@PiinksPiinksAug 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this additional step documented?

@guidezplguidezplAug 29, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is, just something I know. In the status update, there's a link to a manual version of the process, the long term idea being to remove the need for this. The bug assignee has all the info

@PiinksPiinksAug 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I follow. So when we go to run the generator script, we contact the assigned person on that bug to complete another step first?

@guidezplguidezplSep 1, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. So, the generator looks for the latest directory of fonts. New versions of that directory are created (currently, with a manual step) by that Googler.

stuartmorgan-g
stuartmorgan-g approved these changes Aug 29, 2025
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

Comment threadpackages/google_fonts/generator/README.md Outdated
Piinks
Piinks reviewed Sep 4, 2025
View reviewed changes
Comment threadpackages/google_fonts/generator/README.md Outdated
Piinks
Piinks approved these changes Sep 4, 2025
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2025
@auto-submit
auto-submitBot merged commit 91bc1c4 into mainSep 4, 2025
80 checks passed
@auto-submit
auto-submitBot deleted the google-fonts-improvements branch September 4, 2025 19:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2025
@engine-flutter-autoroll
91bc1c4[google_fonts] Improve CONTRIBUTING and generator README (flu…
48267a7
…tter/packages#9917)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2025
@engine-flutter-autoroll
91bc1c4[google_fonts] Improve CONTRIBUTING and generator README (flu…
ce22111
…tter/packages#9917)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Sep 5, 2025
@engine-flutter-autoroll
Roll Packages from98580c6tocab2ac2(2 revisions) (#174998)
145b73a
flutter/packages@98580c6...cab2ac2
2025-09-05 engine-flutter-autoroll@skia.org Roll Flutter from
6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962)
2025-09-04 6655696+guidezpl@users.noreply.github.com [google_fonts]
Improve CONTRIBUTING and generator README (flutter/packages#9917)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@engine-flutter-autoroll@mboetger
Roll Packages from98580c6tocab2ac2(2 revisions) (flutter#174998)
e935095
flutter/packages@98580c6...cab2ac2
2025-09-05 engine-flutter-autoroll@skia.org Roll Flutter from
6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962)
2025-09-04 6655696+guidezpl@users.noreply.github.com [google_fonts]
Improve CONTRIBUTING and generator README (flutter/packages#9917)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
@engine-flutter-autoroll@Jaineel-Mamtora
Roll Packages from98580c6tocab2ac2(2 revisions) (flutter#174998)
4b1c907
flutter/packages@98580c6...cab2ac2
2025-09-05 engine-flutter-autoroll@skia.org Roll Flutter from
6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962)
2025-09-04 6655696+guidezpl@users.noreply.github.com [google_fonts]
Improve CONTRIBUTING and generator README (flutter/packages#9917)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danferreira pushed a commit to danferreira/packages that referenced this pull request Oct 22, 2025
@guidezpl@danferreira
[google_fonts] Improve CONTRIBUTING and generator README (flutter#9917)
19bb6fa
Apply feedback from flutter#9895
Note: the `families_diff` file created by the generator should suffice in writing CHANGELOG updates
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@engine-flutter-autoroll@lucaantonelli
Roll Packages from98580c6tocab2ac2(2 revisions) (flutter#174998)
833b476
flutter/packages@98580c6...cab2ac2
2025-09-05 engine-flutter-autoroll@skia.org Roll Flutter from
6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962)
2025-09-04 6655696+guidezpl@users.noreply.github.com [google_fonts]
Improve CONTRIBUTING and generator README (flutter/packages#9917)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@guidezpl
[google_fonts] Improve CONTRIBUTING and generator README (flutter#9917)
753f195
Apply feedback from flutter#9895
Note: the `families_diff` file created by the generator should suffice in writing CHANGELOG updates
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@PiinksPiinksPiinks approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: google_fonts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guidezpl@stuartmorgan-g@Piinks