Skip to content

[google_sign_in] Add a platform interface method to clear auth tokens - #9929

Merged
auto-submit[bot] merged 17 commits into
flutter:mainfrom
stuartmorgan-g:google-sign-in-add-clear-authorization-p-i
Sep 9, 2025
Merged

[google_sign_in] Add a platform interface method to clear auth tokens#9929
auto-submit[bot] merged 17 commits into
flutter:mainfrom
stuartmorgan-g:google-sign-in-add-clear-authorization-p-i

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Platform interface portion of #9846

Part of flutter/flutter#173924

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 23

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new clearAuthorizationToken method to the platform interface, allowing for the clearing of cached access tokens. The changes are well-structured, including the new method in the abstract class, a corresponding parameter class, and a test to ensure the default implementation throws an UnimplementedError as expected. I have one suggestion regarding a minor naming inconsistency in the documentation to improve clarity. Overall, this is a solid addition to the package.

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2025
@auto-submit
auto-submitBot merged commit 6f979b5 into flutter:mainSep 9, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 10, 2025
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Sep 10, 2025
flutter/packages@2d651b2...03598e7
2025-09-10 stuartmorgan@google.com [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 engine-flutter-autoroll@skia.org Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 stuartmorgan@google.com [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 stuartmorgan@google.com [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 stuartmorgan@google.com Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
flutter/packages@2d651b2...03598e7
2025-09-10 stuartmorgan@google.com [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 engine-flutter-autoroll@skia.org Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 stuartmorgan@google.com [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 stuartmorgan@google.com [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 stuartmorgan@google.com Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
flutter/packages@2d651b2...03598e7
2025-09-10 stuartmorgan@google.com [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 engine-flutter-autoroll@skia.org Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 stuartmorgan@google.com [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 stuartmorgan@google.com [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 stuartmorgan@google.com Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danferreira pushed a commit to danferreira/packages that referenced this pull request Oct 22, 2025
…flutter#9929)
Platform interface portion of flutter#9846
Part of flutter/flutter#173924
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
flutter/packages@2d651b2...03598e7
2025-09-10 stuartmorgan@google.com [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 engine-flutter-autoroll@skia.org Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 stuartmorgan@google.com [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 stuartmorgan@google.com [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 stuartmorgan@google.com Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…flutter#9929)
Platform interface portion of flutter#9846
Part of flutter/flutter#173924
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_sign_in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@bparrishMines