Skip to content

[camera_avfoundation] Implementation swift migration - part 13 - #9930

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
leancodepl:feature/camera-implementation-swift-migration-part13
Sep 29, 2025
Merged

[camera_avfoundation] Implementation swift migration - part 13#9930
auto-submit[bot] merged 4 commits into
flutter:mainfrom
leancodepl:feature/camera-implementation-swift-migration-part13

Conversation

@RobertOdrowaz

@RobertOdrowazRobertOdrowaz commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

Migrates camera implementation as part of flutter/flutter#119109

This PR migrates the last chunk of FLTCam class to Swift:

  • updateOrientation
  • setCaptureSessionPreset
  • Removes FLTCam class

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 23

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the updateOrientation and setCaptureSessionPreset methods from Objective-C to Swift, and subsequently removes the now-obsolete FLTCam class. This is a great step forward in the Swift migration. The implementation looks solid, and I have a couple of minor suggestions to enhance code safety and adopt more idiomatic Swift patterns.

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting!

## 0.9.21+3

* Migrates `updateOrientation` and `setCaptureSessionPreset` methods to Swift.
* Removes `FLTCam` class.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part13 branch 2 times, most recently from e84e04c to aeae649CompareSeptember 10, 2025 18:45
@RobertOdrowaz

Copy link
Copy Markdown
ContributorAuthor

@hellohuanlin take a look at this PR again when you have a moment pls

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertOdrowazRobertOdrowaz added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/9930, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part13 branch from aeae649 to 9f6e214CompareSeptember 24, 2025 06:49
@RobertOdrowaz

Copy link
Copy Markdown
ContributorAuthor

Test exemption reason: refactors with no semantic change (e.g. null safety migrations)

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

test-exempt: code refactor with no semantic change

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Sorry, this will require a merge to re-delete the deleted files; I just landed a mass change that slightly altered the license header of all code files in the repository, which is why there's a conflict here now.

@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-implementation-swift-migration-part13 branch from 9f6e214 to bafa2c5CompareSeptember 29, 2025 14:36
@RobertOdrowazRobertOdrowaz added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025
@auto-submit
auto-submitBot merged commit affa244 into flutter:mainSep 29, 2025
80 checks passed
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Sep 30, 2025
flutter/packages@34eec78...287739d
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
flutter/packages@34eec78...287739d
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
flutter/packages@34eec78...287739d
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…er#9930)
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates the last chunk of `FLTCam` class to Swift:
* `updateOrientation`
* `setCaptureSessionPreset`
* Removes `FLTCam` class
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-iosplatform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertOdrowaz@stuartmorgan-g@hellohuanlin