Skip to content

[camera_platform_interface] implement setDescriptionWhileRecording with android camerax - #9998

Merged
auto-submit[bot] merged 28 commits into
flutter:mainfrom
blackorbs-dev:split-camera-interface
Sep 17, 2025
Merged

[camera_platform_interface] implement setDescriptionWhileRecording with android camerax#9998
auto-submit[bot] merged 28 commits into
flutter:mainfrom
blackorbs-dev:split-camera-interface

Conversation

@blackorbs-dev

Copy link
Copy Markdown
Contributor

implement platform changes for setDescriptionWhileRecording feature with android camerax

Fixes#148013

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 23

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the setDescriptionWhileRecording feature for Android when using CameraX. This is achieved by adding a new enablePersistentRecording option to VideoCaptureOptions, which defaults to true. Documentation has been updated to reflect the new feature and its usage requirements on Android. The package version and changelog have also been updated. My review focuses on improving the changelog entry to be more user-facing and correcting an architectural issue in the documentation where a lower-level package refers to a higher-level one.

Comment threadpackages/camera/camera_platform_interface/CHANGELOG.md Outdated

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelog note

@camsim99 for secondary review

Comment threadpackages/camera/camera_platform_interface/CHANGELOG.md Outdated

@camsim99camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % the changelog change

@bparrishMinesbparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2025
@auto-submit
auto-submitBot merged commit f7af7c2 into flutter:mainSep 17, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2025
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Sep 18, 2025
flutter/packages@fdee698...f2a65fd
2025-09-17 stuartmorgan@google.com [google_sign_in] Add a method to
clear auth tokens (flutter/packages#9846)
2025-09-17 blackorbs.dev@gmail.com [camera_platform_interface] implement
setDescriptionWhileRecording with android camerax
(flutter/packages#9998)
2025-09-17 engine-flutter-autoroll@skia.org Roll Flutter from
8d0b31d to 8f94cb0 (24 revisions) (flutter/packages#10028)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
flutter/packages@fdee698...f2a65fd
2025-09-17 stuartmorgan@google.com [google_sign_in] Add a method to
clear auth tokens (flutter/packages#9846)
2025-09-17 blackorbs.dev@gmail.com [camera_platform_interface] implement
setDescriptionWhileRecording with android camerax
(flutter/packages#9998)
2025-09-17 engine-flutter-autoroll@skia.org Roll Flutter from
8d0b31d to 8f94cb0 (24 revisions) (flutter/packages#10028)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
flutter/packages@fdee698...f2a65fd
2025-09-17 stuartmorgan@google.com [google_sign_in] Add a method to
clear auth tokens (flutter/packages#9846)
2025-09-17 blackorbs.dev@gmail.com [camera_platform_interface] implement
setDescriptionWhileRecording with android camerax
(flutter/packages#9998)
2025-09-17 engine-flutter-autoroll@skia.org Roll Flutter from
8d0b31d to 8f94cb0 (24 revisions) (flutter/packages#10028)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
flutter/packages@fdee698...f2a65fd
2025-09-17 stuartmorgan@google.com [google_sign_in] Add a method to
clear auth tokens (flutter/packages#9846)
2025-09-17 blackorbs.dev@gmail.com [camera_platform_interface] implement
setDescriptionWhileRecording with android camerax
(flutter/packages#9998)
2025-09-17 engine-flutter-autoroll@skia.org Roll Flutter from
8d0b31d to 8f94cb0 (24 revisions) (flutter/packages#10028)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…th android camerax (flutter#9998)
implement platform changes for setDescriptionWhileRecording feature with android camerax
Fixes [#148013](flutter/flutter#148013)
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera_android_camerax] Implement setDescriptionWhileRecording

3 participants

@blackorbs-dev@bparrishMines@camsim99