Skip to content

[simplistic_editor] - Fix delete key on desktop and backspace key on Web - #1458

Merged
domesticmouse merged 4 commits into
flutter:mainfrom
NevercodeHQ:fix_simplistic_editor_backspace_and_delete
Oct 5, 2022
Merged

[simplistic_editor] - Fix delete key on desktop and backspace key on Web#1458
domesticmouse merged 4 commits into
flutter:mainfrom
NevercodeHQ:fix_simplistic_editor_backspace_and_delete

Conversation

@bleroux

@blerouxbleroux commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Description

This PR updates the simplistic_editor sample to fix some issues related to delete and backspace keys.

For full context, see #1424 (comment)

Related issues

Fixes#1450
Fixes#1413

@domesticmouse

domesticmouse commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Can you please re-format for stable?

@blerouxbleroux changed the title [simplistic editor] - Fix delete key on desktop and backspace key on Web[simplistic_editor] - Fix delete key on desktop and backspace key on WebOct 4, 2022
@Renzo-Olivares
Renzo-Olivares self-requested a review October 4, 2022 19:22
Renzo-Olivares
Renzo-Olivares approved these changes Oct 4, 2022
View reviewed changes

@Renzo-OlivaresRenzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides my one comment. Thanks for making this change!

Comment threadsimplistic_editor/lib/basic_text_input_client.dart
@bleroux

bleroux commented Oct 5, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@domesticmouse This PR is almost ready to land. I don't know how to disable this step from CI : verify-web-demos (beta)

When it will be ready, thank you to merge it or to tell me how I should proceed (simply push the Squash and merge button? In flutter/fliutter, I'm used to rely on the autosubmit label, that's why I ask).
FYI, when this PR will be merged, I will update #1447 accordingly.

@domesticmouse

domesticmouse commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

We don't have autosubmit wired up in this repo. Please ignore the failures in the beta web verify. It needs to be updated to honour the beta CI cutout list.

@domesticmouse

domesticmouse commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Please feel free to land once the other CI tasks turn green.

@domesticmouse
domesticmouse merged commit 06a159a into flutter:mainOct 5, 2022
@bleroux
bleroux deleted the fix_simplistic_editor_backspace_and_delete branch October 5, 2022 06:48
@cgestescgestes mentioned this pull request Oct 6, 2022
Merged
@Renzo-OlivaresRenzo-Olivares mentioned this pull request Oct 6, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-OlivaresRenzo-OlivaresRenzo-Olivares approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SimplisticEditor: Strange behavior which text changing on click Simplistic Editor: unexpected behavior of TextInputClient on web

3 participants

@bleroux@domesticmouse@Renzo-Olivares