Skip to content

ScaffoldMessenger Migration Guide - #4527

Merged
sfshaza2 merged 8 commits into
flutter:masterfrom
Piinks:scaffoldMessenger
Oct 13, 2020
Merged

ScaffoldMessenger Migration Guide#4527
sfshaza2 merged 8 commits into
flutter:masterfrom
Piinks:scaffoldMessenger

Conversation

@Piinks

@PiinksPiinks commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

Migration guide for change: flutter/flutter#64101
Change with framework migrations: flutter/flutter#64170
Issue: flutter/flutter#62921

@googlebotgooglebot added the cla: yes Contributor has signed the Contributor License Agreement label Aug 25, 2020
Piinks
Piinks commented Aug 25, 2020
View reviewed changes
Comment threadsrc/docs/release/breaking-changes/index.md Outdated
Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md
Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md Outdated
Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md Outdated
@sfshaza2

sfshaza2 commented Aug 26, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Sorry, @Piinks, but I just landed a largish PR that updates the breaking change files. Please fix the conflicts at your convenience. :) (As this change hasn't landed, I see we are in no rush.)

@PiinksPiinks mentioned this pull request Aug 26, 2020
Merged
12 tasks
sfshaza2
sfshaza2 requested changes Aug 28, 2020
View reviewed changes

@sfshaza2sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get the timeline info, it looks good!

domesticmouse
domesticmouse reviewed Sep 15, 2020
View reviewed changes
Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md
),
));
},
child: const Text('SHOW SNACK'),

@domesticmousedomesticmouseSep 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to use all caps here and above? I'm guessing your intent is to make it obvious that the developer can change these, but it just feels shouty... =)

@PiinksPiinksSep 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was just copying a sample from the API docs. 😜

@domesticmousedomesticmouseSep 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair 😋

@Piinks

Piinks commented Sep 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Update: @sfshaza2 this is still WIP, the change was reverted so we don't have a build tag yet. :)

@PiinksPiinks mentioned this pull request Sep 23, 2020
Merged
9 tasks
Piinks
Piinks commented Oct 12, 2020
View reviewed changes
Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md Outdated
@PiinksPiinks changed the title WIP - ScaffoldMessenger Migration GuideScaffoldMessenger Migration GuideOct 12, 2020
@Piinks
Piinks requested a review from sfshaza2October 12, 2020 18:03
@Piinks

Piinks commented Oct 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@Sfshaza we finally have a build tag for this one, ready to go with your approval! 🎉

This was referenced Oct 12, 2020
Merged
Merged
Merged
Merged
@Hixie

Hixie commented Oct 12, 2020

Copy link
Copy Markdown
Contributor

Please include the error message that you're likely to see if you haven't migrated, so that people can find this by Googling the error message.

sfshaza2
sfshaza2 requested changes Oct 13, 2020
View reviewed changes

@sfshaza2sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor nits but, overall, looks great!

Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md Outdated
);
```

When presenting a `SnackBar` during a transition, the `SnackBar` will `Hero`, animating smoothly to

@sfshaza2sfshaza2Oct 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never heard "Hero" as a verb. Is this a common usage?

@PiinksPiinksOct 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have heard it, but it may mot be common. Updated.

Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md Outdated
Comment threadsrc/docs/release/breaking-changes/scaffold-messenger.md Outdated
@Piinks

Piinks commented Oct 13, 2020

Copy link
Copy Markdown
ContributorAuthor

I've added the error message and applied your suggestion @sfshaza2. Thanks!

sfshaza2
sfshaza2 approved these changes Oct 13, 2020
View reviewed changes

@sfshaza2sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2
sfshaza2 merged commit 13c103b into flutter:masterOct 13, 2020
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
@Piinks@filiph
ScaffoldMessenger Migration Guide (flutter#4527)
5da87ed
* migration guide
* Apply suggestions from code review
* Updates
* Update src/docs/release/breaking-changes/scaffold-messenger.md
* ++
@atsansoneatsansone mentioned this pull request Jun 2, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmousedomesticmousedomesticmouse left review comments
@sfshaza2sfshaza2sfshaza2 approved these changes

Assignees

No one assigned

Labels

cla: yesContributor has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Piinks@sfshaza2@Hixie@domesticmouse@googlebot