Skip to content

Introduce a migration guide for 3.10 new Zone error - #8683

Merged
parlough merged 8 commits into
mainfrom
Hixie-patch-1
May 16, 2023
Merged

Introduce a migration guide for 3.10 new Zone error#8683
parlough merged 8 commits into
mainfrom
Hixie-patch-1

Conversation

@Hixie

@HixieHixie commented May 13, 2023

Copy link
Copy Markdown
Contributor

Migration guide for flutter/flutter#122836

Presubmit checklist

@parloughparlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this document! The background and migration guide read well and make sense to me.

I noted a few issues. Could you also add a link to this doc from the breaking changes index for 3.10? https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L43-L44

Comment threadsrc/release/breaking-changes/zone-errors.md Outdated
Comment threadsrc/release/breaking-changes/zone-errors.md Outdated
Comment threadsrc/release/breaking-changes/zone-errors.md Outdated
Comment threadsrc/release/breaking-changes/zone-errors.md Outdated
Hixieand others added 2 commits May 16, 2023 11:21
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@github-actions

github-actionsBot commented May 16, 2023

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit bce00f0):

https://flutter-docs-prod--pr8683-hixie-patch-1-zg5b0cmh.web.app

(expires Tue, 30 May 2023 18:54:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

@Hixie

Copy link
Copy Markdown
ContributorAuthor

Could you also add a link to this doc from the breaking changes index for 3.10? https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L43-L44

Done. Also fixed the missing items that were in that list.

@parlough

Copy link
Copy Markdown
Member

Thanks! Those link definitions were mostly there by accident and weren't released yet in 3.10 or were already in the list above. I pushed fixes so that the index now matches the state of things.

@parloughparlough changed the title Create zone-errors.mdIntroduce a migration guide for 3.10 new Zone errorMay 16, 2023
@Hixie

Copy link
Copy Markdown
ContributorAuthor

Thanks. I got a bit confused with the list there when doing the merge.

@parloughparlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this and fixing those issues. Looks good to me!

@parloughparlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this and fixing those issues. Looks good to me!

@parlough
parlough merged commit 20f7562 into mainMay 16, 2023
@parlough
parlough deleted the Hixie-patch-1 branch May 16, 2023 19:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hixie@parlough