Uh oh!
There was an error while loading. Please reload this page.
feat(android_alarm_manager_plus): we can now send extra data to alarm manager and receive it in our callback - #1014
Conversation
miquelbeltran
commented
Oct 7, 2022
Hey! Due to changes in our contributor guidelines, all PRs should now:
We would ask you kindly to update the PR following these changes. Thanks! |
miquelbeltran
left a comment
There was a problem hiding this comment.
Thanks for your contribution, I understand what is the goal this new feature is trying to accomplish, but I am not sure if the implementation will open for a lot of more bugs (and alarm_manager_plus is already very unstable unfortunately).
Now on the main branch there are integration tests for alarm_manager_plus. I'd like to ask you to merge main into your working branch and give it a go at adding new integration tests that cover this new functionality.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…_test.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
nohli
left a comment
There was a problem hiding this comment.
A little nit-picking, but in my opinion the code style should be consistent. Plus the method name that has a typo and could be improved and the test description.
Thanks for fixing, I think we can merge very soon 🙏🏽🥳
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Description
Now we can send extra data to alarm manager as Map and also we can receive them in our function callback. For example we can do this :
and in our alarmManagerCallback we can receive the extra params :
Related Issues
Issue 990
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?