Skip to content

fix(device_info_plus): add @Deprecated annotation to toMap method#1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miquelbeltran merged 9 commits into from
Oct 14, 2022
Merged

fix(device_info_plus): add @Deprecated annotation to toMap method #1142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a006de7
[device_info_plus] deprecate toMap
Oct 2, 2022
ff237f8
Revert "[device_info_plus] deprecate toMap"
Oct 2, 2022
850c593
[device_info_plus] add deprecated annotation to toMap method
Oct 2, 2022
828dfbb
[device_info_plus] remove toMap reference from readme
Oct 2, 2022
f8a6693
[device_info_plus] update pubspec and readme
Oct 2, 2022
1560e6e
[device_info_plus_macos] fix typo in pubspec
Oct 2, 2022
691b8d6
[device_info_plus] fix typo in pubspec and changelog for _linux and _web
Oct 2, 2022
04e013d
[device_info] resolve merge conflicts
Oct 7, 2022
fceea3a
Merge branch 'main' into device_info_deprecate_tomap
miquelbeltran Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/device_info_plus/device_info_plus/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,8 +46,6 @@ import 'package:device_info_plus/device_info_plus.dart';

final deviceInfoPlugin = DeviceInfoPlugin();
final deviceInfo = await deviceInfoPlugin.deviceInfo;
final map = deviceInfo.toMap();
// Push [map] to your service.
```

You will find links to the API docs on the [pub page](https://pub.dev/packages/device_info_plus).
Expand Down
2 changes: 2 additions & 0 deletions ...s/device_info_plus/device_info_plus_platform_interface/lib/model/android_device_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,6 +114,7 @@ class AndroidDeviceInfo implements BaseDeviceInfo {
final AndroidDisplayMetrics displayMetrics;

/// Serializes [AndroidDeviceInfo] to map.
@Deprecated('[toMap] method will be discontinued')
@override
Map<String, dynamic> toMap() {
return {
Expand DownExpand Up@@ -216,6 +217,7 @@ class AndroidBuildVersion {
final String? securityPatch;

/// Serializes [ AndroidBuildVersion ] to map.
@Deprecated('[toMap] method will be discontinued')
Map<String, dynamic> toMap() {
return {
'baseOS': baseOS,
Expand Down
1 change: 1 addition & 0 deletions ...ages/device_info_plus/device_info_plus_platform_interface/lib/model/base_device_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
/// The base class for platform's device info.
abstract class BaseDeviceInfo {
/// Serializes device info properties to a map.
@Deprecated('[toMap] method will be discontinued')
Map<String, dynamic> toMap();
}
1 change: 1 addition & 0 deletions packages/device_info_plus/device_info_plus_platform_interface/lib/model/ios_device_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@ class IosDeviceInfo implements BaseDeviceInfo {
}

/// Serializes [IosDeviceInfo] to a map.
@Deprecated('[toMap] method will be discontinued')
@override
Map<String, dynamic> toMap() {
return {
Expand Down
1 change: 1 addition & 0 deletions ...ges/device_info_plus/device_info_plus_platform_interface/lib/model/linux_device_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,7 @@ class LinuxDeviceInfo implements BaseDeviceInfo {
final String? machineId;

/// Serializes [LinuxDeviceInfo] to a map.
@Deprecated('[toMap] method will be discontinued')
@override
Map<String, dynamic> toMap() {
return {
Expand Down
1 change: 1 addition & 0 deletions ...ges/device_info_plus/device_info_plus_platform_interface/lib/model/macos_device_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,6 +55,7 @@ class MacOsDeviceInfo implements BaseDeviceInfo {
final String? systemGUID;

/// Serializes [MacOsDeviceInfo] to map.
@Deprecated('[toMap] method will be discontinued')
@override
Map<String, dynamic> toMap() {
return {
Expand Down
1 change: 1 addition & 0 deletions ...ages/device_info_plus/device_info_plus_platform_interface/lib/model/web_browser_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -129,6 +129,7 @@ class WebBrowserInfo implements BaseDeviceInfo {
}

/// Serializes [WebBrowserInfo] to a map.
@Deprecated('[toMap] method will be discontinued')
@override
Map<String, dynamic> toMap() {
return {
Expand Down
1 change: 1 addition & 0 deletions ...s/device_info_plus/device_info_plus_platform_interface/lib/model/windows_device_info.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,7 @@ class WindowsDeviceInfo implements BaseDeviceInfo {
final String deviceId;

/// Serializes [WindowsDeviceInfo] to a map.
@Deprecated('[toMap] method will be discontinued')
@override
Map<String, dynamic> toMap() {
return {
Expand Down
2 changes: 2 additions & 0 deletions ...ce_info_plus/device_info_plus_platform_interface/test/model/android_device_info_test.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use_from_same_package

import 'package:device_info_plus_platform_interface/model/android_device_info.dart';
import 'package:flutter_test/flutter_test.dart';

Expand Down
2 changes: 2 additions & 0 deletions ...device_info_plus/device_info_plus_platform_interface/test/model/ios_device_info_test.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use_from_same_package

import 'package:device_info_plus_platform_interface/model/ios_device_info.dart';
import 'package:flutter_test/flutter_test.dart';

Expand Down
2 changes: 2 additions & 0 deletions ...vice_info_plus/device_info_plus_platform_interface/test/model/linux_device_info_test.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use_from_same_package

import 'package:device_info_plus_platform_interface/model/linux_device_info.dart';
import 'package:flutter_test/flutter_test.dart';

Expand Down
2 changes: 2 additions & 0 deletions ...vice_info_plus/device_info_plus_platform_interface/test/model/macos_device_info_test.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use_from_same_package

import 'package:device_info_plus_platform_interface/model/macos_device_info.dart';
import 'package:flutter_test/flutter_test.dart';

Expand Down
2 changes: 2 additions & 0 deletions ...evice_info_plus/device_info_plus_platform_interface/test/model/web_browser_info_test.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use_from_same_package

import 'package:device_info_plus_platform_interface/model/web_browser_info.dart';
import 'package:flutter_test/flutter_test.dart';

Expand Down
2 changes: 2 additions & 0 deletions ...ce_info_plus/device_info_plus_platform_interface/test/model/windows_device_info_test.dart
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use_from_same_package

import 'dart:typed_data';
import 'package:device_info_plus_platform_interface/model/windows_device_info.dart';
import 'package:flutter_test/flutter_test.dart';
Expand Down