fix(share_plus): remove `canLaunch` check by SirusCodes · Pull Request #1315 · fluttercommunity/plus_plugins

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

SirusCodes · 2022-11-01T17:42:59Z

Description

Reverting back to old construct as @stuartmorgan suggested #1295 (comment)

Also remove canLaunch check.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

stuartmorgan-g · 2022-11-01T17:50:24Z

- } else {
- throw Exception('Unable to share on web');
- }
+ await urlLauncher.launchUrl(uri.toString(), const LaunchOptions());


Is it intentional that you are ignoring a false return here?

I just reverted it back. Initially it was not returning anything. Also, the API is not returning anything to the user.

Also, the API is not returning anything to the user.
But per the docs for launchUrl:
/// Returns true if the URL was launched successful, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Is having share throw an exception for some failures, but failing completely silently for other failures, really the desired behavior?

cc: @miquelbeltran

For what I can see, we can check the result and throw an exception if it was false.
I think using a plain Exception would be fine here. I will push the changes.

stuartmorgan-g · 2022-11-01T17:50:41Z

Why only Linux? Other implementations were using the same construction.

SirusCodes · 2022-11-01T17:56:37Z

Why only Linux? Other implementations were using the same construction.

Ahh... missed it. Thought it was only used in Linux. Will change them as well.

miquelbeltran · 2022-11-02T06:36:03Z

 }

 /// Share text.
- /// Throws a [PlatformException] if `mailto:` scheme cannot be handled.


Removed for consistency with the other platforms

miquelbeltran · 2022-11-02T06:37:40Z

+ if (!launchResult) {
+ throw Exception('Failed to launch mailto: URI');


As commented, the launchUrl can either return false or fail with an exception, in the case of returning false we throw an Exception.
I did not use PlatformException here because I don't think we should be creating them outside platform code, so I think just a generic Exception is fine here.

Yeah, it makes sense.

SirusCodes · 2022-11-02T19:19:18Z

@miquelbeltran thanks for helping out. This feels fine to me

nohli

Looks good, just not sure if the thrown messages should include $uri instead of mailto: URI.

vbuberen

LGTM

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

fix(share_plus): revert to the older contruct for linux
26ed90f

stuartmorgan-g reviewed Nov 1, 2022
View reviewed changes

feat(share_plus): remove canLaunch check for win and web
90b6cfb

SirusCodes changed the title ~~fix(share_plus): revert to the older contruct for linux~~fix(share_plus): remove canLaunch checkNov 1, 2022

miquelbeltran added 2 commits November 2, 2022 07:29

handle launchUrl result and throw if fail
bfa14da

fix test mock
de129d1

miquelbeltran reviewed Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/test/url_launcher_mock.dart

code formatting
8d3c207

SirusCodes commented Nov 2, 2022
View reviewed changes

Comment threadpackages/share_plus/share_plus/lib/src/share_plus_windows.dart Outdated

chores(share_plus): remove redundant import
c4427dd

miquelbeltran requested review from nohli, stuartmorgan-g and vbuberen and removed request for stuartmorgan-g November 4, 2022 05:34

nohli approved these changes Nov 4, 2022
View reviewed changes

vbuberen approved these changes Nov 4, 2022
View reviewed changes

improved exception message
88ab02c

miquelbeltran merged commit f8f1a0b into fluttercommunity:mainNov 7, 2022

github-actionsBot locked as resolved and limited conversation to collaborators Jan 28, 2025

		if (!launchResult) {
		throw Exception('Failed to launch mailto: URI');

Uh oh!

Uh oh!

Conversation

SirusCodes commented Nov 1, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Breaking Change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Nov 1, 2022

Uh oh!

SirusCodes commented Nov 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SirusCodes commented Nov 2, 2022

Uh oh!

nohli left a comment

Choose a reason for hiding this comment

Uh oh!

vbuberen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

SirusCodes commented Nov 1, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Breaking Change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Nov 1, 2022

Uh oh!

SirusCodes commented Nov 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SirusCodes commented Nov 2, 2022

Uh oh!

SirusCodes commented Nov 1, 2022•
edited
Loading

SirusCodes commented Nov 1, 2022•
edited
Loading

SirusCodes commented Nov 1, 2022•
edited
Loading