Skip to content

feat(device_info_plus): Add Swift Package Manager support - #3167

Merged
vbuberen merged 8 commits into
fluttercommunity:mainfrom
charafau:device_info_spm
Oct 16, 2024
Merged

feat(device_info_plus): Add Swift Package Manager support#3167
vbuberen merged 8 commits into
fluttercommunity:mainfrom
charafau:device_info_spm

Conversation

@charafau

@charafaucharafau commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

ref: #3152

Since SPM support is comming I plan to add it to all plugins.

Followed the guide - https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors
and checked it for both cocoapods and spm

@charafaucharafau changed the title [Device Info] Add Swift Package Manager support for Device infofeat: [Device Info] Add Swift Package Manager support for Device infoAug 9, 2024

@miquelbeltranmiquelbeltran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with the process yet, but took a look at it, and left some comments.

Also, we should do the same for the macOS part of the project, right? In that case, we should indicate in the Title that this only covers iOS

Comment threadpackages/device_info_plus/device_info_plus/.gitignore Outdated
@charafau

Copy link
Copy Markdown
ContributorAuthor

I am not super familiar with the process yet, but took a look at it, and left some comments.

Also, we should do the same for the macOS part of the project, right? In that case, we should indicate in the Title that this only covers iOS

Thanks for fast review, this is also my first time doing it. I will apply suggestions from you and @koji-1009 and upload today. Hopefully migrate all plugins

@charafau

Copy link
Copy Markdown
ContributorAuthor

Thanks guys, should be good now. I also added support for macos

@miquelbeltranmiquelbeltran changed the title feat: [Device Info] Add Swift Package Manager support for Device infofeat(device_info_plus): Add Swift Package Manager support for Device infoAug 12, 2024
@miquelbeltran

miquelbeltran commented Aug 12, 2024

Copy link
Copy Markdown
Member

Please take a look at the macos CI jobs, as they are now failing.

@vbuberenvbuberen changed the title feat(device_info_plus): Add Swift Package Manager support for Device infofeat(device_info_plus): Add Swift Package Manager supportAug 13, 2024
@charafau

Copy link
Copy Markdown
ContributorAuthor

Please take a look at the macos CI jobs, as they are now failing.

Sorry didn't notice that it's a scrollable list 😅 fixed and is passing now

Comment threadpackages/device_info_plus/device_info_plus/ios/device_info_plus.podspec Outdated

@vbuberenvbuberen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and MacOS devices with both SPM on/off and everything works alright.

Thanks for your contribution. Merging.

@vbuberen
vbuberen merged commit 6a347cb into fluttercommunity:mainOct 16, 2024
@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@charafau@miquelbeltran@loic-sharma@vbuberen@koji-1009