Add ethernet as connectivity result - #399
Merged
Merged
Conversation
So far, implemented for Android, Linux, and Web.
Member
|
@jpnurmi This looks good to me, but what do you want to do for Web and iOS, and Windows? should we just return null or an error? |
Member
Author
|
Android, Linux, and Web have been implemented. I also have a working prototype for macOS, but it will follow in a separate PR. On iOS, we can probably use the same. So basically the only remaining platform is Windows, and it seems to be a real pain. Perhaps we can get some Windows expert to help with that. |
Member
|
We have another PR related to connectivity, Maybe we should merge this after that one. although they are not related. |
Member
|
@jpnurmi feel free to resolve conflict and merge and release. |
Member
|
I think this closes #279 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, implemented for Android, Linux, and Web.