Skip to content

fix(android_alarm_manager_plus): Remove deprecated method registerWith #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miquelbeltran merged 2 commits into from
Oct 5, 2021
Merged

fix(android_alarm_manager_plus): Remove deprecated method registerWith #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd4eea0
Remove deprecated method registerWith, remove unused instance, make T…
nohli Oct 5, 2021
8d83daa
Merge branch 'main' into remove-android-v1-embedding
miquelbeltran Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/android_alarm_manager_plus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
## 2.0.0

- Remove deprecated method `registerWith` (of Android v1 embedding)

## 1.3.3

- Fix for periodic alarm being not being exact after some time by adding `allowWhileIdle` parameter


## 1.3.2

- Fix build issue introduced in 1.3.1.
Expand Down
18 changes: 1 addition & 17 deletions ...rc/main/java/dev/fluttercommunity/plus/androidalarmmanager/AndroidAlarmManagerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry.Registrar;
import io.flutter.view.FlutterNativeView;
import org.json.JSONArray;
import org.json.JSONException;
Expand Down Expand Up @@ -41,26 +40,11 @@
* </ol>
*/
public class AndroidAlarmManagerPlugin implements FlutterPlugin, MethodCallHandler {
private static AndroidAlarmManagerPlugin instance;
private final String TAG = "AndroidAlarmManagerPlugin";
private static final String TAG = "AndroidAlarmManagerPlugin";
private Context context;
private Object initializationLock = new Object();
private MethodChannel alarmManagerPluginChannel;

/**
* Registers this plugin with an associated Flutter execution context, represented by the given
* {@link Registrar}.
*
* <p>Once this method is executed, an instance of {@code AndroidAlarmManagerPlugin} will be
* connected to, and running against, the associated Flutter execution context.
*/
public static void registerWith(Registrar registrar) {
if (instance == null) {
instance = new AndroidAlarmManagerPlugin();
}
instance.onAttachedToEngine(registrar.context(), registrar.messenger());
}

@Override
public void onAttachedToEngine(FlutterPluginBinding binding) {
onAttachedToEngine(binding.getApplicationContext(), binding.getBinaryMessenger());
Expand Down
2 changes: 1 addition & 1 deletion packages/android_alarm_manager_plus/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: android_alarm_manager_plus
description: Flutter plugin for accessing the Android AlarmManager service, and
running Dart code in the background when alarms fire.
version: 1.3.3
version: 2.0.0
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/

Expand Down