Linux dartPlugin auto registration - #574
Merged
miquelbeltran merged 14 commits intoOct 27, 2021
Merged
Conversation
pr-Mais
force-pushed
the
linux-registration
branch
from
October 21, 2021 17:41
3da2633 to
622dc76
Compare
jpnurmi
approved these changes
Oct 21, 2021
Member
|
Thanks for cleaning it up! 👍 |
pr-Mais
marked this pull request as ready for review
October 21, 2021 18:36
pr-Mais
force-pushed
the
linux-registration
branch
from
October 22, 2021 10:25
2aa7175 to
87bba71
Compare
pr-Mais
force-pushed
the
linux-registration
branch
from
October 22, 2021 10:27
87bba71 to
af7db2f
Compare
Member
|
hi there! Anything missing or can we merge this now? |
Member
Author
|
Guess it should be good to go cc @jpnurmi |
Member
|
LGTM 👍 |
|
Hi. Don't you need to update the Flutter SDK constraints as well? Also when do you plan to release these changes on pub.dev? |
This was referenced Dec 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the manual endorsement for Linux implementation and add
registerWith&implementskeyword to let Flutter auto register the Dart Linux instance for all plugins.Related Issues
None.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?