Skip to content

feat(device_info_plus): add toMap method to WebBrowserInfo - #593

Merged
miquelbeltran merged 4 commits into
fluttercommunity:mainfrom
marcossevilla:feat/device-info_webInfoToMap
Nov 3, 2021
Merged

feat(device_info_plus): add toMap method to WebBrowserInfo#593
miquelbeltran merged 4 commits into
fluttercommunity:mainfrom
marcossevilla:feat/device-info_webInfoToMap

Conversation

@marcossevilla

@marcossevilla marcossevilla commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

Description

Adds toMap method to serialize WebBrowserInfo on device_info_plus.

Related Issues

Closes #592.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily mhadaily added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 31, 2021

@elias8 elias8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@miquelbeltran

Copy link
Copy Markdown
Member

Thanks for including tests as well! We need to bump the device_info_plus and device_info_plus_platform_interface versions and Changelogs to be able to merge and release. Could you do that @marcossevilla ? the process is explained in the CONTRIBUTING.md as well.

@marcossevilla

Copy link
Copy Markdown
Contributor Author

hi @miquelbeltran, just bumped the versions, let me know if there's anything left and I'm happy to make the change. 👍

@miquelbeltran

Copy link
Copy Markdown
Member

thanks! I think this will work

@miquelbeltran
miquelbeltran merged commit 8fb63fd into fluttercommunity:main Nov 3, 2021
@miquelbeltran

Copy link
Copy Markdown
Member

the packages have been released as well, thanks!

@marcossevilla
marcossevilla deleted the feat/device-info_webInfoToMap branch November 3, 2021 13:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(device_info_plus): add toMap method to WebBrowserInfo model

4 participants