Skip to content

[device_info_plus_ios] fix identifierForVendor - #623

Merged
mhadaily merged 5 commits into
fluttercommunity:mainfrom
alexbatalov:device-info-plus-ios-fix-identifier-for-vendor
Jan 1, 2022
Merged

[device_info_plus_ios] fix identifierForVendor#623
mhadaily merged 5 commits into
fluttercommunity:mainfrom
alexbatalov:device-info-plus-ios-fix-identifier-for-vendor

Conversation

@alexbatalov

Copy link
Copy Markdown
Contributor

Description

This PR likely fixes #621. Of all used UIDevice properties only identifierForVendor is marked as nullable. However the circumstances when it is null are hard to reproduce, so it's a guess.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Like in the other PR, could you also add a new entry on the CHANGELOG and update the version number in the pubspec? thanks!

@miquelbeltran

Copy link
Copy Markdown
Member

hey @alexbatalov some conflicts appeared, could you fix them? please ping me when ready and I will merge

@alexbatalov

Copy link
Copy Markdown
Contributor Author

@miquelbeltran I've updated version and changelog, but there is other failing check, see #661, which fixes failing test in package_info_plus, which itself fails because there is a missing changelog in network_info_plus (see #655).

@miquelbeltran

Copy link
Copy Markdown
Member

thanks @alexbatalov I will finish merging and releasing once I am back in the office

@vbuberen vbuberen mentioned this pull request Dec 29, 2021
9 tasks
@mhadaily

mhadaily commented Jan 1, 2022

Copy link
Copy Markdown
Member

@alexbatalov can you please resolve the conflicts then I will merge and release a new package.

@mhadaily mhadaily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhadaily
mhadaily merged commit d0132c5 into fluttercommunity:main Jan 1, 2022
@alexbatalov
alexbatalov deleted the device-info-plus-ios-fix-identifier-for-vendor branch January 19, 2022 12:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[device_info_plus] crash

4 participants