Added Card Widgets (_DevListCardFirst and _DevListCardSecond) by bisunajaime · Pull Request #246 · flutterph/devs

bisunajaime · 2021-02-11T04:29:32Z

File: dev_list.dart
Added card widgets to list of devs
Icons to be updated to socials, temporarily material icons
Can try out card dark mode by changing isDark to true

File: devboard_page.dart
modified DevboardPage widget, for fixed card list view sizing
Added ListType enum
Added other card types to Devboard Page

File: devs.json
Added socials

Card demo 1: https://imgur.com/vWuCXhX
Card demo 2: https://imgur.com/V1jslVt

File: dev_list.dart Added card widgets to list of devs Icons to be updated to socials, temporarily material icons Can try out card dark mode by changing isDark to true File: devboard_page.dart modified DevboardPage widget, for fixed card list view sizing Added ListType enum Added other card types to Devboard Page File: devs.json Added socials

Jansalvador1445 · 2021-02-11T04:32:29Z

Woah! I liked the design! But it has conflicts :( Please rebase.

bisunajaime · 2021-02-11T04:50:11Z

This is noted. Thanks!

Jansalvador1445 · 2021-02-11T05:06:24Z

Still has Conflict. I'm excited more to merge to! :D

bisunajaime · 2021-02-11T05:31:53Z

Hello, could I ask for help on this. I'm very new to this as it is my first time contributing.

Jansalvador1445 · 2021-02-11T05:44:16Z

Sure, wait let me, check your repo.

File: dev_list.dart Added card widgets to list of devs Icons to be updated to socials, temporarily material icons Can try out card dark mode by changing isDark to true File: devboard_page.dart modified DevboardPage widget, for fixed card list view sizing Added ListType enum Added other card types to Devboard Page File: devs.json Added socials

bisunajaime · 2021-02-11T06:00:49Z

I think I got it to work, though I may have to comment out some of the list views in the devboard_page.dart

Modified devboard_page.dart Still shows grid, but can be changed by changing the "listType" parameter.

…nto 229/josejaime # Conflicts: # lib/features/devboard/devboard_page.dart # lib/features/devboard/devs/devs_list.dart

Jansalvador1445 · 2021-02-11T07:15:29Z

Added changes here, but please fix the overflow of the text :D

Jansalvador1445 · 2021-02-11T07:54:18Z

And the card shadow, i think i accidentally removed it.

bisunajaime · 2021-02-11T08:02:54Z

Fixed the overflow issue by increasing the height of the card and added maxLines in Text widgets to avoid overflowing

Jansalvador1445 · 2021-02-11T09:29:25Z

Will test it now.

Jansalvador1445 · 2021-02-11T09:34:38Z

+ child: Consumer<List<Dev>>(
+ builder: (_, data, __) => DevsList(
+ devs: data,
+ listType: ListType.CARD_FIRST,


I think we don't need this one

Jansalvador1445 · 2021-02-11T09:34:56Z

 import 'package:font_awesome_flutter/font_awesome_flutter.dart';
 import 'package:url_launcher/url_launcher.dart';

+enum ListType { AVATAR, CARD_FIRST, CARD_SECOND, GRID }


I think we dont need this

Jansalvador1445 · 2021-02-11T09:35:02Z

+
 class DevsList extends StatelessWidget {
 final List<Dev> devs;
+ final ListType listType;


remove this one

Jansalvador1445 · 2021-02-11T09:35:10Z

 const DevsList({
 Key key,
 this.devs = const [],
+ this.listType = ListType.GRID,


remove this one

Jansalvador1445 · 2021-02-11T09:35:19Z

 /// Sort dev's ascending
 devs.sort((a, b) => a.name.compareTo(b.name));

+ if (this.listType == ListType.AVATAR) {


remove this one

Jansalvador1445 · 2021-02-11T09:35:57Z

+ );
+ }
+
+ if (this.listType == ListType.CARD_FIRST) {


let's remove conditional statement, will use Card_first

Jansalvador1445 · 2021-02-11T09:36:08Z

+ );
+ }
+
+ if (this.listType == ListType.CARD_SECOND) {


remove this one

Jansalvador1445 · 2021-02-11T09:36:18Z

 }
 }

+class _DevListCardSecond extends StatelessWidget {


remove this one

Jansalvador1445 · 2021-02-11T09:37:03Z

+ }
+}
+
+class _DevListCardFirst extends StatelessWidget {


From _DevListCardFirst to _DevListCard

Jansalvador1445 · 2021-02-11T09:37:48Z

+ Widget build(BuildContext context) {
+ final bool isDark = false;
+
+ final Color lightColor = Colors.white.withOpacity(.6);


Let's add this to the Constant/Colors file or folder.

Jansalvador1445 · 2021-02-11T09:38:23Z

+ final Color lightColor = Colors.white.withOpacity(.6);
+ final Color darkColor = Colors.black.withOpacity(.6);
+
+ final TextStyle title = TextStyle(


I think we could embed this to the destionation

Could you clarify on this, where can I find the destination file/folder?

lib/constant/colors.dart -> please add colors.dart
class ColorConstant { //Some Codes }

Jansalvador1445 · 2021-02-11T09:42:20Z

@@ -4,6 +4,8 @@ import 'package:devs/features/devboard/devs/devs_list.dart';
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';



Remove space

Jansalvador1445 · 2021-02-11T09:43:04Z

+ }
+}
+
 class _DevListItem extends StatelessWidget {


Remove this, since we will use the Second card

No need for this will be removed.

Jansalvador1445 · 2021-02-11T10:10:05Z

Can we do this(vertical position but same design/ui)? What do you think?

bisunajaime · 2021-02-11T10:15:49Z

Can we do this(vertical position but same design/ui)? What do you think?

Sure, I'll try it out right now.

Jansalvador1445 · 2021-02-11T11:06:24Z

When I get home, i'll try to push on your branch.

bisunajaime · 2021-02-11T12:50:19Z

I think it\s working. I made use of the other card I made awhile ago for mobile because the other card causes some of the widgets to overflow. Will push this in my branch now.

Jansalvador1445 · 2021-02-11T12:54:06Z

Nice! Will check it now.

Added colors.dart file in core/constants folder for text colors to be added Made use of Card grid in devboard_page.dart Made use of the other card format for mobile screens due to the widget overflow of the other card.

Jansalvador1445 · 2021-02-11T13:15:51Z

Just pushed on your branch, can you git pull then test it out? If there's an error on it. thanks

Jansalvador1445 · 2021-02-11T13:16:28Z

If everything is good, we can merge this one.

Fixed alignment of CircleAvatar, and mobile gridview because some widgets were overflowing.

bisunajaime · 2021-02-11T13:34:45Z

Got it, no errors encountered, though I experienced some widget overflowing but was able to fix it in my latest push.

Jansalvador1445 · 2021-02-11T17:44:17Z

This is good on my side. Merging this now.

Jansalvador1445 · 2021-02-11T17:44:30Z

Congrats @jose-bamboo! Wohooo! :D

bisunajaime · 2021-02-13T06:15:21Z

Congrats @jose-bamboo! Wohooo! :D

Really late reply, but thank you so much for the help! :)

joshuadeguzman · 2021-02-15T02:08:12Z

@allcontributors please add @jose-bamboo for design, code

allcontributors · 2021-02-15T02:08:20Z

@joshuadeguzman

I've put up a pull request to add @jose-bamboo! 🎉

joshuadeguzman · 2021-02-15T02:09:25Z

@allcontributors please add @Jansalvador1445 for mentoring, code, bug

allcontributors · 2021-02-15T02:09:32Z

@joshuadeguzman

I've put up a pull request to add @Jansalvador1445! 🎉

bisunajaime closed this Feb 11, 2021

bisunajaime reopened this Feb 11, 2021

Merge remote-tracking branch 'upstream/master' into 229/josejaime
fe22483

bisunajaime force-pushed the 229/josejaime branch from fe22483 to 98d6b42Compare February 11, 2021 05:58

bisunajaimeand others added 2 commits February 11, 2021 14:15

Added GRID list type to ListType enum
5df9512
Modified devboard_page.dart Still shows grid, but can be changed by changing the "listType" parameter.

Merge branch '229/josejaime' ofhttps://github.com/jose-bamboo/devsi…
ddf8f55
…nto 229/josejaime # Conflicts: # lib/features/devboard/devboard_page.dart # lib/features/devboard/devs/devs_list.dart

Fixed overflow issue, and updated some overwritten files.
690644e

Jansalvador1445 reviewed Feb 11, 2021
View reviewed changes

bisunajaimeand others added 2 commits February 11, 2021 20:55

Added colors.dart, card grid, mobile responsive
094e031
Added colors.dart file in core/constants folder for text colors to be added Made use of Card grid in devboard_page.dart Made use of the other card format for mobile screens due to the widget overflow of the other card.

Fix and removed unused codes
b27cc6f

Update devs_list.dart
95099f2
Fixed alignment of CircleAvatar, and mobile gridview because some widgets were overflowing.

Jansalvador1445 merged commit aecd2f0 into flutterph:masterFeb 11, 2021

joshuadeguzman added this to the Devboard 🏆 milestone Feb 12, 2021

joshuadeguzman added #30daysOfFlutter 1 point 2 points 3 points and removed 1 point 2 points labels Feb 15, 2021

allcontributorsBot mentioned this pull request Feb 15, 2021
docs: add jose-bamboo as a contributor #303
Merged

allcontributorsBot mentioned this pull request Feb 15, 2021
docs: add Jansalvador1445 as a contributor #304
Merged

		@@ -4,6 +4,8 @@ import 'package:devs/features/devboard/devs/devs_list.dart';
		import 'package:flutter/material.dart';
		import 'package:provider/provider.dart';

Uh oh!

Conversation

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

Jansalvador1445 commented Feb 11, 2021

Uh oh!

bisunajaime commented Feb 13, 2021

Uh oh!

joshuadeguzman commented Feb 15, 2021

bisunajaime commented Feb 11, 2021•
edited
Loading