Skip to content

Added loading indicator before loading DevsList - #282

Merged
joshuadeguzman merged 39 commits into
flutterph:masterfrom
coyksdev:feat/loading-indicator-before-loading-devs
Feb 16, 2021
Merged

Added loading indicator before loading DevsList#282
joshuadeguzman merged 39 commits into
flutterph:masterfrom
coyksdev:feat/loading-indicator-before-loading-devs

Conversation

@coyksdev

@coyksdevcoyksdev commented Feb 13, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @Jansalvador1445, adding loading indicator before loading DevsList.

https://i.imgur.com/UHg4uVG.gif

Stephen Janseen Baloand others added 17 commits February 13, 2021 06:24
Stephen Janseen Balo
Add Stephen Janseen D. Balo details
883fe35
@coyksdev
Added loading indicator before loading DevsList
2f1d08e
@vinceramcesoliveros
Merge pull requestflutterph#281from pure-edge/280/pure-edge
c15ea90
Add Stephen Janseen D. Balo details
@nixdorgu
add Anike Dorgu socials
5083d32
@joshuadeguzman
feat: Add search bar
c702f1d
@joshuadeguzman
Add working search 🚀
e1d826e
@jedau
Add Jed Aureus Gonzales details
8b5abe2
@Jansalvador1445
Merge pull requestflutterph#283from nixdorgu/dorgu-socials
c5f5722
Add Anike Dorgu socials
@allcontributors
docs: update README.md [skip ci]
4c6828e
@allcontributors
docs: update .all-contributorsrc [skip ci]
6b8f6e4
@Jansalvador1445
Merge pull requestflutterph#288from jedau/286/Jed-Aureus-Gonzales
0654c93
Add Jed Aureus Gonzales details
@Jansalvador1445
Merge pull requestflutterph#292from flutterph/all-contributors/add-…
f3eb21f
…jedau
docs: add jedau as a contributor
@OliverRhyme
Add Oliver Rhyme G. Añasco details
730af00
@allcontributors
docs: update README.md [skip ci]
155c8b5
@allcontributors
docs: update .all-contributorsrc [skip ci]
7193bb4
@Jansalvador1445
Merge pull requestflutterph#285from OliverRhyme/flutterph#284/olive…
7c3b72a
…r-añasco
Add Oliver Rhyme G. Añasco details
@Jansalvador1445
Merge pull requestflutterph#294from flutterph/all-contributors/add-…
364aa8b
…OliverRhyme
docs: add OliverRhyme as a contributor
@Jansalvador1445

Jansalvador1445 commented Feb 14, 2021

Copy link
Copy Markdown
Contributor

Has Conflict, please rebase.

tanmherand others added 12 commits February 15, 2021 04:48
@tanmher
Add Mher John Tan details
5526c9c
@allcontributors
docs: update README.md [skip ci]
9fef9c5
@allcontributors
docs: update .all-contributorsrc [skip ci]
b798a87
@Jansalvador1445
Merge pull requestflutterph#298from tanmher/297/mher
f013e94
Add Mher John Tan details
@Jansalvador1445
Merge pull requestflutterph#300from flutterph/all-contributors/add-…
8f800d9
…tanmher
docs: add tanmher as a contributor
@allcontributors
docs: update README.md [skip ci]
911cfdb
@allcontributors
docs: update .all-contributorsrc [skip ci]
09dcd52
@joshuadeguzman
Merge pull requestflutterph#303from flutterph/all-contributors/add-…
d6ffdb3
…jose-bamboo
docs: add jose-bamboo as a contributor
@allcontributors
docs: update README.md [skip ci]
3cf3e7d
@allcontributors
docs: update .all-contributorsrc [skip ci]
1837475
@joshuadeguzman
Merge branch 'master' into all-contributors/add-Jansalvador1445
ab7bbe9
@joshuadeguzman
Merge pull requestflutterph#304from flutterph/all-contributors/add-…
6a64280
…Jansalvador1445
docs: add Jansalvador1445 as a contributor
@joshuadeguzmanjoshuadeguzman added this to the Devboard 🏆 milestone Feb 15, 2021
@joshuadeguzman

joshuadeguzman commented Feb 15, 2021

Copy link
Copy Markdown
Member

Hello @campanagerald

Please address the rebase conflict :D

If possible, I recommend adding a screenshot for feature and design related changes. cc: @Jansalvador1445

Thanks for your PR!

@coyksdev

coyksdev commented Feb 15, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

HI @joshuadeguzman@Jansalvador1445 , i am having a hard time switching from stable to beta branch. After flutter upgrade, I am always stuck in Building flutter tool stage. so I decided to stick in the stable branch. being said that, i would like to close this issue and give this task to other devs :)

@coyksdev

coyksdev commented Feb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

HI @joshuadeguzman@Jansalvador1445 , i am having a hard time switching from stable to beta branch. After flutter upgrade, I am always stuck in Building flutter tool stage. so I decided to stick in the stable branch. being said that, i would like to close this issue and give this task to other devs :)

Hi @Jansalvador1445@joshuadeguzman disregard this, I was able to fix the issue. I am working on this now. thanks :D

@coyksdev

coyksdev commented Feb 16, 2021

Copy link
Copy Markdown
ContributorAuthor

@Jansalvador1445 boss pa review po. :D Maraming salamat!

Jansalvador1445
Jansalvador1445 approved these changes Feb 16, 2021
View reviewed changes

@Jansalvador1445Jansalvador1445 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Approved on my side. @joshuadeguzman could you also review this one.

@joshuadeguzman
joshuadeguzman merged commit 7b08f35 into flutterph:masterFeb 16, 2021
@OliverRhymeOliverRhyme mentioned this pull request Feb 16, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jansalvador1445Jansalvador1445Jansalvador1445 approved these changes

Assignees

@coyksdevcoyksdev

Labels

2 points#30daysOfFlutter

Projects

None yet

Milestone

Devboard 🏆

Development

Successfully merging this pull request may close these issues.

8 participants

@coyksdev@Jansalvador1445@joshuadeguzman@vinceramcesoliveros@nixdorgu@jedau@OliverRhyme@tanmher