Skip to content

Animated heart loader for devs page - #346

Open
mgcarpizo wants to merge 40 commits into
flutterph:masterfrom
mgcarpizo:345/mgcarpizo
Open

Animated heart loader for devs page#346
mgcarpizo wants to merge 40 commits into
flutterph:masterfrom
mgcarpizo:345/mgcarpizo

Conversation

@mgcarpizo

Copy link
Copy Markdown
Contributor

Closes#345

Zacharias02and others added 30 commits February 14, 2021 16:13
…om jobs page
Fix dev page bug where the page is stuck in loading when switching from jobs page
…JackofAllTradesDev
docs: add JackofAllTradesDev as a contributor
…OliverRhyme
docs: add OliverRhyme as a contributor
…Zacharias02
docs: add Zacharias02 as a contributor
@joshuadeguzman

Copy link
Copy Markdown
Member

Hi @mgcarpizo! Thank you for this! :) Congrats for the shoutout.

Would it be possible if we rebase this to the latest master? I also recommend not including changes that are unrelated to this pull request 😄

Right now, there are about 75K+ line of changes 😅

@vinceramcesoliverosvinceramcesoliveros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

…o 345/mgcarpizo
# Conflicts:
#	lib/features/dashboard/dashboard_page.dart
#	lib/features/devboard/devboard_page.dart
#	lib/features/devboard/devs/devs_list.dart
#	lib/loader.dart
#	pubspec.lock
#	pubspec.yaml
@mgcarpizo

Copy link
Copy Markdown
ContributorAuthor

@joshuadeguzman Hi! I've rebased and merged the changes :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Add heart loader for page loads

7 participants

@mgcarpizo@joshuadeguzman@vinceramcesoliveros@Zacharias02@OliverRhyme@paulcedo@MapleSyyrup