Uh oh!
There was an error while loading. Please reload this page.
chore: add pull request template - #5
Merged
Merged
Conversation
Adds a PR template covering the two things most easily missed in this monorepo: per-package version bumps and CHANGELOG entries. Every package here is published to pub.dev independently, so a user-visible fix that doesn't bump pubspec.yaml never reaches anyone — which is exactly what happened in #4. The template also asks whether a change was verified on real hardware rather than only the simulator, since the simulator's sandbox is more permissive and masks device-only failures, and prompts contributors to flag behaviour changes and sibling packages affected by the same tvOS constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/pull_request_template.md. The repo had no template and noCONTRIBUTING.md.Why
The two things easiest to miss in this monorepo are per-package version bumps and CHANGELOG entries. Every package here is published to pub.dev independently, so a user-visible fix that doesn't bump
pubspec.yamlnever actually reaches anyone. #4 is a live example — a correct, well-tested fix that would have shipped to nobody.The template also:
Modelled on the
flutter-tvostemplate, adapted for per-package versioning (nodevbranch here, and no shared[Unreleased]section since versions are independent).