[pr into #785] Format cleanup - #803
Merged
wild-endeavor merged 13 commits intoJan 7, 2022
Merged
wild-endeavor merged 13 commits into
wild-endeavor merged 13 commits into
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov Report
@@ Coverage Diff @@
## structured-dataset-proposal #803 +/- ##
===============================================================
+ Coverage 85.59% 85.60% +0.01%
===============================================================
Files 353 353
Lines 30388 30465 +77
Branches 3666 3674 +8
===============================================================
+ Hits 26010 26080 +70
- Misses 3706 3716 +10
+ Partials 672 669 -3
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
…org/flytekit into structured-dataset-proposal-format
pingsutw
approved these changes
Jan 7, 2022
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_formatfield from the pythonStructuredDatasetobject. It will default to "parquet", and will only be settable by the user throughAnnotate. This should be okay because we don't see format to be used too often.""in case a matching format cannot be found.Encoderinterface to addstructured_literal_type: StructuredDatasetTypeas an input argument. The reason is because we want contributors to be able to fill in/potentially modify the type information that's embedded in the literal.StructuredDatasetto also be parquet, otherwiseStructuredDataset[my_cols]got a format of "" instead of parquet.