Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Go 1.16 -> Go 1.18 - #266
Merged
Merged
Conversation
Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
Codecov Report
@@ Coverage Diff @@## master #266 +/- ##
==========================================
- Coverage 62.55% 62.55% -0.01%
==========================================
Files 142 142 Lines 8961 8960 -1 ==========================================
- Hits 5606 5605 -1
Misses 2834 2834 Partials 521 521
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
mayitbeegh
marked this pull request as ready for review
June 3, 2022 00:11
EngHabu
approved these changes
Jun 3, 2022
eapolinario pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Sean Lin <sean@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Starting from v1.46.0,
golangci-lintno longer works with Go 1.16. This causes PR checks to fail, example https://github.com/flyteorg/flyteplugins/runs/6632158946?check_suite_focus=trueThis PR fixes the PR checks by upgrading from Go 1.16 to Go 1.18.
End-to-end tested in flytepropeller and flyteadmin
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
Follow-up issue
NA