Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Add opentelemetry instrumentation - #146

Open
hamersaw wants to merge 11 commits into
masterfrom
feature/open-telemetry
Open

Add opentelemetry instrumentation#146
hamersaw wants to merge 11 commits into
masterfrom
feature/open-telemetry

Conversation

@hamersaw

@hamersawhamersaw commented Nov 23, 2022

Copy link
Copy Markdown
Member

TL;DR

Adding a new telemetryutils package that adapts the opentelemetry functionality for use in Flyte repos. This includes support for multiple TracerProviders allowing logical partitioning of tracers within single binary. Also instruments the blobstore and provides a wrapper for instrumenting k8s client.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#3304

Follow-up issue

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
@codecov

codecovBot commented Nov 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #146 (9cbeef9) into master (3322b07) will decrease coverage by 1.44%.
The diff coverage is 40.20%.

@@ Coverage Diff @@## master #146 +/- ##
==========================================
- Coverage 68.18% 66.75% -1.44% 
==========================================
Files 69 73 +4 Lines 4083 4268 +185 ==========================================
+ Hits 2784 2849 +65 - Misses 1141 1249 +108 - Partials 158 170 +12 
FlagCoverage Δ
unittests66.75% <40.20%> (-1.44%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
cli/pflags/api/namedtype_enumer.go0.00% <ø> (ø)
storage/config.go66.66% <ø> (ø)
storage/storage.go100.00% <ø> (ø)
storage/utils.go65.00% <0.00%> (-5.28%)⬇️
telemetryutils/config.go0.00% <0.00%> (ø)
telemetryutils/k8s.go0.00% <0.00%> (ø)
telemetryutils/config_flags.go25.00% <25.00%> (ø)
storage/stow_store.go75.70% <31.81%> (-3.85%)⬇️
telemetryutils/factory.go64.51% <64.51%> (ø)
storage/mem_store.go82.00% <81.81%> (-0.93%)⬇️
... and 3 more

... and 1 file with indirect coverage changes

Signed-off-by: Dan Rammer <daniel@union.ai>
@hamersaw

Copy link
Copy Markdown
MemberAuthor

closed in favor of #149

Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
@hamersaw
hamersaw marked this pull request as ready for review March 11, 2023 01:56
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
@kumare3

Copy link
Copy Markdown
Contributor

Does it also change are
Dependency from Prometheus to
Open telemetry? Should we

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hamersaw@kumare3