feat(ui): harness icon in the terminal header (visible on mobile), truncate long session names - #100
Merged
Merged
Conversation
…long session names On mobile the sidebar is hidden behind the Terminal tab, so the terminal header is the only place identifying the current session — but it showed a generic ›_ glyph with no indication of which agent the session runs. Render the session's HarnessIcon there (falling back to ›_ only when the shell type is unknown), mirroring the desktop sidebar rows. Shows on all breakpoints; the icon is purely additive. While verifying at a 390px viewport, the header's flex row lacked min-w-0, so a long session name (a full agent command) never engaged its ellipsis and instead widened the page past the viewport, clipping the header and the mobile key toolbar. Add min-w-0 + overflow-hidden so the name truncates and the page stays within width; the icon keeps shrink-0. Verified in an isolated Docker container at 390x844: the harness icon renders before the name, the long name ellipsizes, and scrollWidth / innerWidth stay at 390 with no horizontal overflow. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On mobile the sidebar is hidden behind the Terminal tab, so the terminal header is the only thing identifying the current session — but it showed a generic
›_glyph with no sign of which agent the session runs.HarnessIconin the terminal header (Terminal.tsx), falling back to›_only when the shell type is unknown. Mirrors the desktop sidebar rows (SessionList.tsx). Shows on all breakpoints; purely additive.min-w-0, so a long session name (a full agent command) never truncated and instead widened the page past the viewport, clipping the header and the on-screen key toolbar. Addedmin-w-0 overflow-hidden; the icon keepsshrink-0, so only the name ellipsizes.Verification
Isolated Docker container serving this branch's panel, real Chromium at 390×844 (isMobile), codex session with a long name:
[data-harness-icon="codex"]);document.documentElement.scrollWidthandwindow.innerWidthboth stay 390 — no horizontal overflow.tscclean; existingHarnessIcontests pass. Screenshot in the review notes.Single file:
ui/src/components/Terminal.tsx.🤖 Generated with Claude Code