Use classic locale grouping without locale support - #4947
Open
tiagomacarios wants to merge 2 commits into
Open
tiagomacarios wants to merge 2 commits into
tiagomacarios wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4941.
When
FMT_USE_LOCALE=0, keep accepting theLspecifier but use classic/C locale semantics. In particular, localized floating-point formatting no longer applies the fallback comma grouping; integer behavior is unchanged.The second commit converts
nolocale-testfrom a compile-only target into a registered executable and verifies localized integer and floating-point output at runtime. Chrono locale handling remains separate in #4921.Tested with MSVC 19.51 using
FMT_PEDANTIC=ON: