Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 1 commit into from
Mar 11, 2019
Merged

Fix saving loca index format/version when subsetting #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/subset/TTFSubset.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
this.glyf = [];
this.offset = 0;
this.loca = {
offsets: []
offsets: [],
version: this.font.loca.version

@devongovettdevongovettMar 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.

@blikblumblikblumMar 7, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.

Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers

In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.

To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.

};

this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
maxp.numGlyphs = this.glyf.length;

this.loca.offsets.push(this.offset);
Tables.loca.preEncode.call(this.loca);

let head = cloneDeep(this.font.head);
head.indexToLocFormat = this.loca.version;
Expand Down
5 changes: 0 additions & 5 deletions src/tables/loca.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
if (this.version != null) return;

// assume this.offsets is a sorted array
this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

if (this.version === 0) {
for (let i = 0; i < this.offsets.length; i++) {
this.offsets[i] >>>= 1;
Expand Down
17 changes: 17 additions & 0 deletions test/subset.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
done();
}));
});

it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');

@devongovettdevongovettMar 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.

@blikblumblikblumMar 12, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me

let subset = font.createSubset();
for (let glyph of font.glyphsForString('abcd')) {
subset.includeGlyph(glyph);
}

subset.encodeStream().pipe(concat(function(buf) {
let f = fontkit.create(buf);
assert.equal(f.numGlyphs, 5);
assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
// must test also second glyph which has an odd loca index
assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
done();
}));
});
});

describe('CFF subsetting', function() {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix saving loca index format/version when subsetting#191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

devongovett
merged 1 commit into

from

Mar 11, 2019
 Merged


Fix saving loca index format/version when subsetting
#191
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/subset/TTFSubset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,8 @@ export default class TTFSubset extends Subset {
 this.glyf = [];
 this.offset = 0;
 this.loca = {
 offsets: []
 offsets: [],
 version: this.font.loca.version
@devongovettdevongovettMar 7, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause us to switch to the large format sometimes when not needed. For example, if the original font contained a lot of glyphs, but the subset only contains a few, then we shouldn't need to use the large format.
@blikblumblikblumMar 7, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a issue because the subset size would still be proportional to the original font. Say we have a font with 1000 glyphs with same size, a subset with 100 glyphs of such font would have the expected 10% size of the original.
Also is not doable to convert from large to short format because would require to make all offsets even numbers, needing to add some sort of data padding complicating things at write and read time. This could even work with fontkit but would not work for, e.g, pdf readers
In a font i was testing (NanumGothic) the .notdef (id 0) glyph has a size of 87 bytes = the offset of the first glyph in the subset. Since the short format requires the offset to be stored divided by 2, it saves as 43. When reading the subset, the offset is multiplied by 2 getting 86 -> the glyph data is read incorrectly.
To convert to short format it would need pad the id 0 glyph (or any odd sized glyph) to have one more byte or store a lookup somewhere the glyphs that need to have the offset corrected at read time. This should work in fontkit only and the complexity (and size increase) is not worth.
 };

 this.hmtx = {
Expand All@@ -77,7 +78,6 @@ export default class TTFSubset extends Subset {
 maxp.numGlyphs = this.glyf.length;

 this.loca.offsets.push(this.offset);
 Tables.loca.preEncode.call(this.loca);

 let head = cloneDeep(this.font.head);
 head.indexToLocFormat = this.loca.version;
Expand Down

5 changes: 0 additions & 5 deletions
src/tables/loca.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,11 +18,6 @@ loca.process = function() {
};

loca.preEncode = function() {
 if (this.version != null) return;

 // assume this.offsets is a sorted array
 this.version = this.offsets[this.offsets.length - 1] > 0xffff ? 1 : 0;

 if (this.version === 0) {
 for (let i = 0; i < this.offsets.length; i++) {
 this.offsets[i] >>>= 1;
Expand Down

17 changes: 17 additions & 0 deletions
test/subset.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,23 @@ describe('font subsetting', function() {
 done();
 }));
 });

 it('should handle fonts with long index to location format (indexToLocFormat = 1)', function(done) {
 let font = fontkit.openSync(__dirname + '/data/FiraSans/FiraSans-Regular.ttf');
@devongovettdevongovettMar 11, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this font wasn't committed.
@blikblumblikblumMar 12, 2019

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for committing it for me
 let subset = font.createSubset();
 for (let glyph of font.glyphsForString('abcd')) {
 subset.includeGlyph(glyph);
 }

 subset.encodeStream().pipe(concat(function(buf) {
 let f = fontkit.create(buf);
 assert.equal(f.numGlyphs, 5);
 assert.equal(f.getGlyph(1).path.toSVG(), font.glyphsForString('a')[0].path.toSVG());
 // must test also second glyph which has an odd loca index
 assert.equal(f.getGlyph(2).path.toSVG(), font.glyphsForString('b')[0].path.toSVG());
 done();
 }));
 });
 });

 describe('CFF subsetting', function() {
Expand Down