Skip to content

Update build to babel 7 and configure to compile to modern targets - #196

Closed
blikblum wants to merge 4 commits into
foliojs:masterfrom
blikblum:update-babel
Closed

Update build to babel 7 and configure to compile to modern targets#196
blikblum wants to merge 4 commits into
foliojs:masterfrom
blikblum:update-babel

Conversation

@blikblum

Copy link
Copy Markdown
Member

This updates the build system to use babel 7 and configure it to target modern systems.

Together with foliojs/dfa#1 allows to remove a bunch of big and slow code

Comment thread.babelrc
[
"@babel/preset-env",
{
"targets": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could do both a modern and a legacy build? I think a good number of people still need to support IE 11.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added es5 (ie11) compatible build

@blikblum

Copy link
Copy Markdown
MemberAuthor

Rebased on top of master to fix conflict

@tgabi333

Copy link
Copy Markdown

👍

Comment threadrollup.config.js
}
}

const modernBrowsers = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth using https://github.com/browserslist/browserslist instead?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done is a followup PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given how much further into the future things are now, it's probably worth updating this to https://github.com/browserslist/browserslist rather than in followup at this point. Just in case it takes another year before it actually lands =(

@Pomax

Copy link
Copy Markdown
Contributor

@devongovett good to merge?

@joewestcott

Copy link
Copy Markdown

Please can this be merged @devongovett

@mohd-akram

Copy link
Copy Markdown

Any update on this?

@russell-dot-js

Copy link
Copy Markdown

bruh

@crespinb

Copy link
Copy Markdown

could this be merged?

@redstone99

Copy link
Copy Markdown

Would be great to get this merged in...

@davecarlson

Copy link
Copy Markdown

is there any update to this? It's been 2 years!

You mention on the pdfkit github this ticket, we want to know if it's likely to be merged, or if we need to move to a different supported library

@vsachini

Copy link
Copy Markdown

Could this be merged?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@blikblum@tgabi333@Pomax@joewestcott@mohd-akram@russell-dot-js@crespinb@redstone99@davecarlson@vsachini@devongovett