Skip to content

Korean characters missing - displayed blank #914

Description

@Avital-Kapiloff

Bug Report

Description of the problem

I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
I checked over 10 different fonts for Korean and all of them are missing characters.
(https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
vfs_fonts.js.zip

after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

If you could recommend how to solve it I will really appreciate it. Thanks!

Code sample

import pdfMake from "pdfmake/build/pdfmake";
import pdfFonts from "other/vfs_fonts";
pdfMake.fonts = {
"Roboto":{
"bold":"Roboto-Medium.ttf",
"normal":"Roboto-Regular.ttf"},
"NanumGothic":{
"bold": 'NanumGothic-Regular.ttf',
"normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
"normal": 'NotoSansEthiopic-Regular.ttf',
"bold": 'NotoSansEthiopic-Bold.ttf'}
};
function getFont(string) {
if (checkAmharic(string)) {
return "amharic_font";
} else if (checkKorean(string)) {
return "korean_font";
} else {
return "default_font";
}
}
function checkAmharic(x) {
return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
}
function checkKorean(x) {
return /[가-힣]+/.test(x); // will return true if an Korean letter is present
}
var caseDocDefinition = {
content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
'German: Ä Ö Ü ä ö ü ß',
'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
'Romanian-1: Ă Â Î Ş Ţ',
'Romanian-2: ă â î ş ţ',
'Slovenian-1: Č Š Ž',
'Slovenian-1: č š ž',
'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
'Special: § ´ ² ³ ° µ €',
'polish: Cześć',
{width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
{width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
{width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
],
defaultStyle: {
font: "Roboto"
},
styles: {
amharic_font: {
font: "NotoSansEthiopic",
margin: [10,0,0,2]
},
korean_font: {
font: "NanumGothic",
margin: [10,0,0,2]
},
default_font: {
font: "Roboto",
margin: [10,0,0,2]
}
}
}
/* Create the pdf */
pdfMake.createPdf(caseDocDefinition).open();

Your environment

  • pdfkit version: v0.8.3 / v0.9.0
  • Node version: v8.12.0
  • Browser version (if applicable): Google Chrome Version 71.0.3578.98
  • Operating System: Mac

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      Issue · GitHub
      Skip to content

      Korean characters missing - displayed blank #914

      Description

      @Avital-Kapiloff

      Bug Report

      Description of the problem

      I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

      using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
      I checked over 10 different fonts for Korean and all of them are missing characters.
      (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
      vfs_fonts.js.zip

      after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

      at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

      If you could recommend how to solve it I will really appreciate it. Thanks!

      Code sample

      import pdfMake from "pdfmake/build/pdfmake";
      import pdfFonts from "other/vfs_fonts";
      pdfMake.fonts = {
      "Roboto":{
      "bold":"Roboto-Medium.ttf",
      "normal":"Roboto-Regular.ttf"},
      "NanumGothic":{
      "bold": 'NanumGothic-Regular.ttf',
      "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
      "normal": 'NotoSansEthiopic-Regular.ttf',
      "bold": 'NotoSansEthiopic-Bold.ttf'}
      };
      function getFont(string) {
      if (checkAmharic(string)) {
      return "amharic_font";
      } else if (checkKorean(string)) {
      return "korean_font";
      } else {
      return "default_font";
      }
      }
      function checkAmharic(x) {
      return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
      }
      function checkKorean(x) {
      return /[가-힣]+/.test(x); // will return true if an Korean letter is present
      }
      var caseDocDefinition = {
      content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
      'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
      'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
      'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
      'German: Ä Ö Ü ä ö ü ß',
      'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
      'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
      'Romanian-1: Ă Â Î Ş Ţ',
      'Romanian-2: ă â î ş ţ',
      'Slovenian-1: Č Š Ž',
      'Slovenian-1: č š ž',
      'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
      'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
      'Special: § ´ ² ³ ° µ €',
      'polish: Cześć',
      {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
      {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
      {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
      ],
      defaultStyle: {
      font: "Roboto"
      },
      styles: {
      amharic_font: {
      font: "NotoSansEthiopic",
      margin: [10,0,0,2]
      },
      korean_font: {
      font: "NanumGothic",
      margin: [10,0,0,2]
      },
      default_font: {
      font: "Roboto",
      margin: [10,0,0,2]
      }
      }
      }
      /* Create the pdf */
      pdfMake.createPdf(caseDocDefinition).open();
      

      Your environment

      • pdfkit version: v0.8.3 / v0.9.0
      • Node version: v8.12.0
      • Browser version (if applicable): Google Chrome Version 71.0.3578.98
      • Operating System: Mac

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Issue · GitHub
          Skip to content

          Korean characters missing - displayed blank #914

          Description

          @Avital-Kapiloff

          Bug Report

          Description of the problem

          I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

          using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
          I checked over 10 different fonts for Korean and all of them are missing characters.
          (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
          vfs_fonts.js.zip

          after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

          at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

          If you could recommend how to solve it I will really appreciate it. Thanks!

          Code sample

          import pdfMake from "pdfmake/build/pdfmake";
          import pdfFonts from "other/vfs_fonts";
          pdfMake.fonts = {
          "Roboto":{
          "bold":"Roboto-Medium.ttf",
          "normal":"Roboto-Regular.ttf"},
          "NanumGothic":{
          "bold": 'NanumGothic-Regular.ttf',
          "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
          "normal": 'NotoSansEthiopic-Regular.ttf',
          "bold": 'NotoSansEthiopic-Bold.ttf'}
          };
          function getFont(string) {
          if (checkAmharic(string)) {
          return "amharic_font";
          } else if (checkKorean(string)) {
          return "korean_font";
          } else {
          return "default_font";
          }
          }
          function checkAmharic(x) {
          return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
          }
          function checkKorean(x) {
          return /[가-힣]+/.test(x); // will return true if an Korean letter is present
          }
          var caseDocDefinition = {
          content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
          'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
          'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
          'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
          'German: Ä Ö Ü ä ö ü ß',
          'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
          'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
          'Romanian-1: Ă Â Î Ş Ţ',
          'Romanian-2: ă â î ş ţ',
          'Slovenian-1: Č Š Ž',
          'Slovenian-1: č š ž',
          'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
          'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
          'Special: § ´ ² ³ ° µ €',
          'polish: Cześć',
          {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
          {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
          {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
          ],
          defaultStyle: {
          font: "Roboto"
          },
          styles: {
          amharic_font: {
          font: "NotoSansEthiopic",
          margin: [10,0,0,2]
          },
          korean_font: {
          font: "NanumGothic",
          margin: [10,0,0,2]
          },
          default_font: {
          font: "Roboto",
          margin: [10,0,0,2]
          }
          }
          }
          /* Create the pdf */
          pdfMake.createPdf(caseDocDefinition).open();
          

          Your environment

          • pdfkit version: v0.8.3 / v0.9.0
          • Node version: v8.12.0
          • Browser version (if applicable): Google Chrome Version 71.0.3578.98
          • Operating System: Mac

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Issue · GitHub
              Skip to content

              Korean characters missing - displayed blank #914

              Description

              @Avital-Kapiloff

              Bug Report

              Description of the problem

              I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

              using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
              I checked over 10 different fonts for Korean and all of them are missing characters.
              (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
              vfs_fonts.js.zip

              after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

              at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

              If you could recommend how to solve it I will really appreciate it. Thanks!

              Code sample

              import pdfMake from "pdfmake/build/pdfmake";
              import pdfFonts from "other/vfs_fonts";
              pdfMake.fonts = {
              "Roboto":{
              "bold":"Roboto-Medium.ttf",
              "normal":"Roboto-Regular.ttf"},
              "NanumGothic":{
              "bold": 'NanumGothic-Regular.ttf',
              "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
              "normal": 'NotoSansEthiopic-Regular.ttf',
              "bold": 'NotoSansEthiopic-Bold.ttf'}
              };
              function getFont(string) {
              if (checkAmharic(string)) {
              return "amharic_font";
              } else if (checkKorean(string)) {
              return "korean_font";
              } else {
              return "default_font";
              }
              }
              function checkAmharic(x) {
              return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
              }
              function checkKorean(x) {
              return /[가-힣]+/.test(x); // will return true if an Korean letter is present
              }
              var caseDocDefinition = {
              content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
              'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
              'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
              'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
              'German: Ä Ö Ü ä ö ü ß',
              'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
              'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
              'Romanian-1: Ă Â Î Ş Ţ',
              'Romanian-2: ă â î ş ţ',
              'Slovenian-1: Č Š Ž',
              'Slovenian-1: č š ž',
              'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
              'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
              'Special: § ´ ² ³ ° µ €',
              'polish: Cześć',
              {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
              {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
              {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
              ],
              defaultStyle: {
              font: "Roboto"
              },
              styles: {
              amharic_font: {
              font: "NotoSansEthiopic",
              margin: [10,0,0,2]
              },
              korean_font: {
              font: "NanumGothic",
              margin: [10,0,0,2]
              },
              default_font: {
              font: "Roboto",
              margin: [10,0,0,2]
              }
              }
              }
              /* Create the pdf */
              pdfMake.createPdf(caseDocDefinition).open();
              

              Your environment

              • pdfkit version: v0.8.3 / v0.9.0
              • Node version: v8.12.0
              • Browser version (if applicable): Google Chrome Version 71.0.3578.98
              • Operating System: Mac

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Issue · GitHub
                  Skip to content

                  Korean characters missing - displayed blank #914

                  Description

                  @Avital-Kapiloff

                  Bug Report

                  Description of the problem

                  I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

                  using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
                  I checked over 10 different fonts for Korean and all of them are missing characters.
                  (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
                  vfs_fonts.js.zip

                  after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

                  at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

                  If you could recommend how to solve it I will really appreciate it. Thanks!

                  Code sample

                  import pdfMake from "pdfmake/build/pdfmake";
                  import pdfFonts from "other/vfs_fonts";
                  pdfMake.fonts = {
                  "Roboto":{
                  "bold":"Roboto-Medium.ttf",
                  "normal":"Roboto-Regular.ttf"},
                  "NanumGothic":{
                  "bold": 'NanumGothic-Regular.ttf',
                  "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
                  "normal": 'NotoSansEthiopic-Regular.ttf',
                  "bold": 'NotoSansEthiopic-Bold.ttf'}
                  };
                  function getFont(string) {
                  if (checkAmharic(string)) {
                  return "amharic_font";
                  } else if (checkKorean(string)) {
                  return "korean_font";
                  } else {
                  return "default_font";
                  }
                  }
                  function checkAmharic(x) {
                  return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
                  }
                  function checkKorean(x) {
                  return /[가-힣]+/.test(x); // will return true if an Korean letter is present
                  }
                  var caseDocDefinition = {
                  content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
                  'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
                  'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
                  'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
                  'German: Ä Ö Ü ä ö ü ß',
                  'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
                  'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
                  'Romanian-1: Ă Â Î Ş Ţ',
                  'Romanian-2: ă â î ş ţ',
                  'Slovenian-1: Č Š Ž',
                  'Slovenian-1: č š ž',
                  'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
                  'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
                  'Special: § ´ ² ³ ° µ €',
                  'polish: Cześć',
                  {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
                  {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
                  {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
                  ],
                  defaultStyle: {
                  font: "Roboto"
                  },
                  styles: {
                  amharic_font: {
                  font: "NotoSansEthiopic",
                  margin: [10,0,0,2]
                  },
                  korean_font: {
                  font: "NanumGothic",
                  margin: [10,0,0,2]
                  },
                  default_font: {
                  font: "Roboto",
                  margin: [10,0,0,2]
                  }
                  }
                  }
                  /* Create the pdf */
                  pdfMake.createPdf(caseDocDefinition).open();
                  

                  Your environment

                  • pdfkit version: v0.8.3 / v0.9.0
                  • Node version: v8.12.0
                  • Browser version (if applicable): Google Chrome Version 71.0.3578.98
                  • Operating System: Mac

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Issue · GitHub
                      Skip to content

                      Korean characters missing - displayed blank #914

                      Description

                      @Avital-Kapiloff

                      Bug Report

                      Description of the problem

                      I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

                      using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
                      I checked over 10 different fonts for Korean and all of them are missing characters.
                      (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
                      vfs_fonts.js.zip

                      after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

                      at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

                      If you could recommend how to solve it I will really appreciate it. Thanks!

                      Code sample

                      import pdfMake from "pdfmake/build/pdfmake";
                      import pdfFonts from "other/vfs_fonts";
                      pdfMake.fonts = {
                      "Roboto":{
                      "bold":"Roboto-Medium.ttf",
                      "normal":"Roboto-Regular.ttf"},
                      "NanumGothic":{
                      "bold": 'NanumGothic-Regular.ttf',
                      "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
                      "normal": 'NotoSansEthiopic-Regular.ttf',
                      "bold": 'NotoSansEthiopic-Bold.ttf'}
                      };
                      function getFont(string) {
                      if (checkAmharic(string)) {
                      return "amharic_font";
                      } else if (checkKorean(string)) {
                      return "korean_font";
                      } else {
                      return "default_font";
                      }
                      }
                      function checkAmharic(x) {
                      return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
                      }
                      function checkKorean(x) {
                      return /[가-힣]+/.test(x); // will return true if an Korean letter is present
                      }
                      var caseDocDefinition = {
                      content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
                      'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
                      'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
                      'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
                      'German: Ä Ö Ü ä ö ü ß',
                      'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
                      'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
                      'Romanian-1: Ă Â Î Ş Ţ',
                      'Romanian-2: ă â î ş ţ',
                      'Slovenian-1: Č Š Ž',
                      'Slovenian-1: č š ž',
                      'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
                      'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
                      'Special: § ´ ² ³ ° µ €',
                      'polish: Cześć',
                      {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
                      {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
                      {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
                      ],
                      defaultStyle: {
                      font: "Roboto"
                      },
                      styles: {
                      amharic_font: {
                      font: "NotoSansEthiopic",
                      margin: [10,0,0,2]
                      },
                      korean_font: {
                      font: "NanumGothic",
                      margin: [10,0,0,2]
                      },
                      default_font: {
                      font: "Roboto",
                      margin: [10,0,0,2]
                      }
                      }
                      }
                      /* Create the pdf */
                      pdfMake.createPdf(caseDocDefinition).open();
                      

                      Your environment

                      • pdfkit version: v0.8.3 / v0.9.0
                      • Node version: v8.12.0
                      • Browser version (if applicable): Google Chrome Version 71.0.3578.98
                      • Operating System: Mac

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Issue · GitHub
                          Skip to content

                          Korean characters missing - displayed blank #914

                          Description

                          @Avital-Kapiloff

                          Bug Report

                          Description of the problem

                          I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

                          using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
                          I checked over 10 different fonts for Korean and all of them are missing characters.
                          (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
                          vfs_fonts.js.zip

                          after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

                          at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

                          If you could recommend how to solve it I will really appreciate it. Thanks!

                          Code sample

                          import pdfMake from "pdfmake/build/pdfmake";
                          import pdfFonts from "other/vfs_fonts";
                          pdfMake.fonts = {
                          "Roboto":{
                          "bold":"Roboto-Medium.ttf",
                          "normal":"Roboto-Regular.ttf"},
                          "NanumGothic":{
                          "bold": 'NanumGothic-Regular.ttf',
                          "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
                          "normal": 'NotoSansEthiopic-Regular.ttf',
                          "bold": 'NotoSansEthiopic-Bold.ttf'}
                          };
                          function getFont(string) {
                          if (checkAmharic(string)) {
                          return "amharic_font";
                          } else if (checkKorean(string)) {
                          return "korean_font";
                          } else {
                          return "default_font";
                          }
                          }
                          function checkAmharic(x) {
                          return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
                          }
                          function checkKorean(x) {
                          return /[가-힣]+/.test(x); // will return true if an Korean letter is present
                          }
                          var caseDocDefinition = {
                          content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
                          'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
                          'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
                          'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
                          'German: Ä Ö Ü ä ö ü ß',
                          'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
                          'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
                          'Romanian-1: Ă Â Î Ş Ţ',
                          'Romanian-2: ă â î ş ţ',
                          'Slovenian-1: Č Š Ž',
                          'Slovenian-1: č š ž',
                          'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
                          'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
                          'Special: § ´ ² ³ ° µ €',
                          'polish: Cześć',
                          {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
                          {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
                          {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
                          ],
                          defaultStyle: {
                          font: "Roboto"
                          },
                          styles: {
                          amharic_font: {
                          font: "NotoSansEthiopic",
                          margin: [10,0,0,2]
                          },
                          korean_font: {
                          font: "NanumGothic",
                          margin: [10,0,0,2]
                          },
                          default_font: {
                          font: "Roboto",
                          margin: [10,0,0,2]
                          }
                          }
                          }
                          /* Create the pdf */
                          pdfMake.createPdf(caseDocDefinition).open();
                          

                          Your environment

                          • pdfkit version: v0.8.3 / v0.9.0
                          • Node version: v8.12.0
                          • Browser version (if applicable): Google Chrome Version 71.0.3578.98
                          • Operating System: Mac

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Issue · GitHub
                              Skip to content

                              Korean characters missing - displayed blank #914

                              Description

                              @Avital-Kapiloff

                              Bug Report

                              Description of the problem

                              I'm using pdfMake to create a PDF. I check the content of the text and only then decide what font to use depending on the language it's working fine except the Korean.

                              using this font https://fonts.google.com/specimen/Nanum+Gothic?selection.family=Nanum+Gothic&selection.subset=korean.
                              I checked over 10 different fonts for Korean and all of them are missing characters.
                              (https://www.google.com/get/noto/#sans-kore or https://fonts.google.com/?subset=korean)
                              vfs_fonts.js.zip

                              after a lot of research i fond a font that works KaigenSansSC-*.ttf (https://github.com/m13253/kaigen-fonts) but it's a very hevy (23.MB) font and and prefer using something smaller.

                              at pdfmake they say it mayve an issue in pdfkit... bpampuch/pdfmake#1614

                              If you could recommend how to solve it I will really appreciate it. Thanks!

                              Code sample

                              import pdfMake from "pdfmake/build/pdfmake";
                              import pdfFonts from "other/vfs_fonts";
                              pdfMake.fonts = {
                              "Roboto":{
                              "bold":"Roboto-Medium.ttf",
                              "normal":"Roboto-Regular.ttf"},
                              "NanumGothic":{
                              "bold": 'NanumGothic-Regular.ttf',
                              "normal": 'NanumGothic-Regular.ttf'}, "NotoSansEthiopic":{
                              "normal": 'NotoSansEthiopic-Regular.ttf',
                              "bold": 'NotoSansEthiopic-Bold.ttf'}
                              };
                              function getFont(string) {
                              if (checkAmharic(string)) {
                              return "amharic_font";
                              } else if (checkKorean(string)) {
                              return "korean_font";
                              } else {
                              return "default_font";
                              }
                              }
                              function checkAmharic(x) {
                              return /[\u1200-\u137F]/.test(x); // will return true if an amharic letter is present
                              }
                              function checkKorean(x) {
                              return /[가-힣]+/.test(x); // will return true if an Korean letter is present
                              }
                              var caseDocDefinition = {
                              content: [ 'ASCII-1: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z',
                              'ASCII-2: a b c d e f g h i j k l m n o p q r s t u v w x y z',
                              'ASCII-3: 0 1 2 3 4 5 6 7 8 9',
                              'ASCII-4: . , : ; - _ ! ? / " \' ` ^ ~ * + = \\ | # $ @ % & ( ) < > [ ] { }',
                              'German: Ä Ö Ü ä ö ü ß',
                              'Czech-1: Á Č Ď É Ě Í Ň Ó Ř Š Ť Ú Ů Ý Ž',
                              'Czech-2: á č ď é ě í ň ó ř š ť ú ů ý ž',
                              'Romanian-1: Ă Â Î Ş Ţ',
                              'Romanian-2: ă â î ş ţ',
                              'Slovenian-1: Č Š Ž',
                              'Slovenian-1: č š ž',
                              'Slowak-1: Á Ä Č Ď É Í Ľ Ĺ Ň Ó Ô Ŕ Š Ť Ú Ý Ž',
                              'Slowak-2: á ä č ď é í ľ ĺ ň ó ô ŕ š ť ú ý ž',
                              'Special: § ´ ² ³ ° µ €',
                              'polish: Cześć',
                              {width:350, text: '여보세요', style: getFont('여보세요'), alignment: 'justify'},
                              {width:350, text: 'some other text', style: getFont('some other text'), alignment: 'justify'},
                              {width:350, text: 'ሰላም', style: getFont('ሰላም'), alignment: 'justify'}
                              ],
                              defaultStyle: {
                              font: "Roboto"
                              },
                              styles: {
                              amharic_font: {
                              font: "NotoSansEthiopic",
                              margin: [10,0,0,2]
                              },
                              korean_font: {
                              font: "NanumGothic",
                              margin: [10,0,0,2]
                              },
                              default_font: {
                              font: "Roboto",
                              margin: [10,0,0,2]
                              }
                              }
                              }
                              /* Create the pdf */
                              pdfMake.createPdf(caseDocDefinition).open();
                              

                              Your environment

                              • pdfkit version: v0.8.3 / v0.9.0
                              • Node version: v8.12.0
                              • Browser version (if applicable): Google Chrome Version 71.0.3578.98
                              • Operating System: Mac

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions