Skip to content

Week3 - #24

Open
Nouransaeed wants to merge 15 commits into
foocoding:masterfrom
Nouransaeed:week3
Open

Week3#24
Nouransaeed wants to merge 15 commits into
foocoding:masterfrom
Nouransaeed:week3

Conversation

@Nouransaeed

Copy link
Copy Markdown

week 3

Comment threadWeek1/homework/app.js
@@ -1,11 +1,122 @@
'use strict';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an extra space here. In fact, I think there looks like to be lots of strange spacing. Can you run prettier on your files so they fix the formatting issues?

Comment threadWeek1/homework/app.js Outdated
}

document.body.appendChild(ul);
document.body.onload = listBooks;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Think you'll have to do Prettier for everything. See how the indentation is off here?

Comment threadWeek1/homework/app.js Outdated
li.textContent = title[i];

ul.appendChild(li);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this actually adding elements to the screen. Do you see anything on yours? You have to then add the ul to the DOM.

Comment threadWeek1/homework/app.js Outdated
'use strict';

'use strict';
{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This opening bracket will cause problems...

Comment threadWeek1/homework/index.html Outdated


</body>
</html>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange spacing here too


function doubleOddNumbers(numbers) {

numbers = numbers.filter(num => num % 2 === 1).map(num => num * 2);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! But there seems to be many blank lines above and below. Can you delete?

@@ -0,0 +1,133 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange spacing in this file too. Too many blank lines. Needs Prettier formatting.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Nouransaeed@grod220