Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3
feat!: upgrade to ESLint 10 @W-23474795@#412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
689243ebc26b2acd008f9ac676cfdc862f9775b711678e20586d96e54f9d17bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Copyright 2026, Salesforce, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import eslint from '@eslint/js'; | ||
| import globals from 'globals'; | ||
| import eslintConfigPrettier from 'eslint-config-prettier'; | ||
| import headerPlugin from '@tony.ganchev/eslint-plugin-header'; | ||
| export default [ | ||
| { | ||
| ignores: ['node_modules/**', 'coverage/**'], | ||
| }, | ||
| eslint.configs.recommended, | ||
| { | ||
| languageOptions: { | ||
| ecmaVersion: 2021, | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| plugins: { | ||
| header: headerPlugin, | ||
| }, | ||
| rules: { | ||
| 'header/header': [ | ||
| 2, | ||
| 'block', | ||
| [ | ||
| '', | ||
| { | ||
| pattern: ' \\* Copyright \\d{4}, Salesforce, Inc\\.', | ||
| template: ' * Copyright 2026, Salesforce, Inc.', | ||
| }, | ||
| ' *', | ||
| ' * Licensed under the Apache License, Version 2.0 (the "License");', | ||
| ' * you may not use this file except in compliance with the License.', | ||
| ' * You may obtain a copy of the License at', | ||
| ' *', | ||
| ' * http://www.apache.org/licenses/LICENSE-2.0', | ||
| ' *', | ||
| ' * Unless required by applicable law or agreed to in writing, software', | ||
| ' * distributed under the License is distributed on an "AS IS" BASIS,', | ||
| ' * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.', | ||
| ' * See the License for the specific language governing permissions and', | ||
| ' * limitations under the License.', | ||
| ' ', | ||
| ], | ||
| ], | ||
| }, | ||
| }, | ||
| { | ||
| files: ['test/**/*.js'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.mocha, | ||
| }, | ||
| }, | ||
| }, | ||
| eslintConfigPrettier, | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default } from 'eslint-config-salesforce-typescript'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default } from 'eslint-config-salesforce-typescript'; |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@salesforce/dev-scripts", | ||
| "version": "11.0.4", | ||
| "version": "12.0.0", | ||
| "description": "Standardize package.json scripts and config files for Salesforce projects.", | ||
| "repository": "forcedotcom/dev-scripts", | ||
| "bin": { | ||
| @@ -15,7 +15,7 @@ | ||
| "lint": "eslint \"{files,test,utils,bin}/**/*.js\"", | ||
| "clean": "bin/sf-clean.js", | ||
| "clean-all": "bin/sf-clean.js all", | ||
| "fix-license": "eslint utils files/*.cjs test --fix --rule \"header/header: [2]\"", | ||
| "fix-license": "eslint utils files/*.mjs test --fix --rule \"header/header: [2]\"", | ||
| "test": "nyc mocha test/**/*.test.js", | ||
| "prepare": "husky install" | ||
| }, | ||
| @@ -28,42 +28,56 @@ | ||
| "bin", | ||
| "utils", | ||
| "files", | ||
| "sfEslintConfig.mjs", | ||
| "sfEslintConfig-strict.mjs", | ||
| "sfdevrc.schema.json", | ||
| "core-plugins.json", | ||
| "jit-plugins.json" | ||
| ], | ||
| "exports": { | ||
| "./sfEslintConfig": "./sfEslintConfig.mjs", | ||
| "./sfEslintConfig-strict": "./sfEslintConfig-strict.mjs", | ||
| "./package.json": "./package.json" | ||
| }, | ||
| "dependencies": { | ||
| "@commitlint/cli": "^17.8.1", | ||
| "@commitlint/config-conventional": "^17.8.1", | ||
| "@salesforce/dev-config": "^4.3.3", | ||
| "@salesforce/prettier-config": "^0.0.3", | ||
| "@types/chai": "^4.3.14", | ||
| "@salesforce/prettier-config": "^0.0.4", | ||
| "@types/chai": "^4.3.17", | ||
| "@types/mocha": "^10.0.10", | ||
| "@types/node": "^18", | ||
| "@types/sinon": "^10.0.20", | ||
| "chai": "^4.3.10", | ||
| "chai": "^4.5.0", | ||
| "chalk": "^4.0.0", | ||
| "cosmiconfig": "^8.3.6", | ||
| "eslint-config-salesforce-typescript": "4.0.1", | ||
jfeingold35 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| "@eslint/js": "^10.0.0", | ||
| "@tony.ganchev/eslint-plugin-header": "^3.4.4", | ||
| "eslint-config-prettier": "^10.1.5", | ||
| "eslint-config-salesforce-typescript": "^6.0.0", | ||
| "globals": "^15.14.0", | ||
| "husky": "^7.0.4", | ||
| "linkinator": "^6.1.2", | ||
| "linkinator": "^6.3.0", | ||
| "mocha": "^10.8.2", | ||
| "nyc": "^17.0.0", | ||
| "nyc": "^17.1.0", | ||
| "prettier": "^2.8.8", | ||
| "pretty-quick": "^3.3.1", | ||
| "shelljs": "^0.10.0", | ||
| "sinon": "10.0.0", | ||
| "source-map-support": "^0.5.21", | ||
| "ts-node": "^10.9.2", | ||
| "typedoc": "^0.26.5", | ||
| "typedoc": "^0.26.11", | ||
| "typedoc-plugin-missing-exports": "^3.1.0", | ||
| "typescript": "^5.5.4", | ||
| "typescript": "^5.5.4 || ^6", | ||
| "wireit": "^0.14.13" | ||
| }, | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "devDependencies": { | ||
| "eslint": "^8.57.1" | ||
| "eslint": "^10.4.0" | ||
| }, | ||
| "overrides": { | ||
| "browserslist": "4.24.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default } from 'eslint-config-salesforce-typescript'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default } from 'eslint-config-salesforce-typescript'; |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason these went away? did the lint rules change in an unexpected way as part of this pr? or not get applied to
binor something?