Uh oh!
There was an error while loading. Please reload this page.
fix: stop ignoring CMakeLists.txt in .gitignore - #152
Merged
Conversation
CMakeLists.txt is tracked, but .gitignore excluded it, which made packaging tools that use .gitignore to decide sdist contents (rather than git's tracked-file list) silently drop it from the sdist. Also ignore common Python packaging output directories (dist, wheelhouse, *.egg-info). Extracted from #151. Co-Authored-By: Antonio Leblanc <antonio.leblanc@umgrauemeio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #151 (credited to @HugoFara, who wrote this fix as part of that PR).
CMakeLists.txtis tracked, but.gitignoreexcluded it, which makes packaging tools that read.gitignoreto decide what to include (rather than git's own tracked-file list) silently drop it from the sdist. Also ignores common Python packaging output directories (dist,wheelhouse,*.egg-info) ahead of the wheel-packaging work in #151.Standalone and unrelated to the open macOS wheel issue on #151, so merging this now unblocks it independently of that discussion.
I want to merge this first so that @HugoFara becomes a contributor to the project to enable him to launch the actions on the repository. which are allowed only by people who alterdy contributed