Uh oh!
There was an error while loading. Please reload this page.
Backport the CHANGELOG to dev, with the dev-only entries - #185
Merged
Conversation
The repository has seven tags and six GitHub releases, and no file that tells a user what changed between them. `pip install forefire` makes that worse: someone pinning a version has the release notes on GitHub and nothing in the tree. CHANGELOG.md reconstructs every release from the release notes and the commit history. Claims that could be checked were checked against the tags: listenHTTP and RothermelAndrews2018 are absent at v1.2 and present at v2.0, the geojson dump mode is absent at v1.1.10. [Unreleased] lists only what is on this branch, forefireAPI#154 and forefireAPI#155. The dev branch carries a longer list in its own copy, which supersedes this one when dev is merged. CONTRIBUTING.md now asks for an entry, so the file stays current instead of being reconstructed again in a year. Its link to a testing page pointed at a Read the Docs URL that has never existed; it points at TESTING.md, which nothing in the repository linked to. (cherry picked from commit cc7e1789c66432aec56673993c3b6e198e0525a0)
The CHANGELOG landed on master carries only forefireAPI#154 and forefireAPI#155 under [Unreleased], because that is all master has. This adds the ten pull requests merged into dev since: the unit suite, the moisture invariants, the sanitizer job, the HTTP characterisation tests, the threading reproduction, and the shared-state and double-free fixes. Two things went stale on dev while that work landed, both of them ours. The README's CMake option table stopped at six options; forefireAPI#156 and forefireAPI#180 added FOREFIRE_BUILD_TESTS, FOREFIRE_ENABLE_WARNINGS, FOREFIRE_WARNINGS_AS_ERRORS and FOREFIRE_SANITIZE. And CONTRIBUTING told contributors to run `cd tests && bash run.bash`, which does not reach the C++ unit tests at all; ctest does.
HugoFara
commented
Aug 12, 2026
CollaboratorAuthor
#184 should be merged first, holding on this one. |
This was referenced Aug 12, 2026
antonio-leblanc
self-requested a review
August 13, 2026 04:19
antonio-leblanc
approved these changes
Aug 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #184 to
dev, plus the entries and options that only exist here.The first commit is #184 cherry-picked unchanged. The second adds what
masterdoes not have.The
[Unreleased]section#184 lists #154 and #155, because that is all
masterhas. This adds the ten pull requests merged intodevsince v2.5.0: the unit suite (#156), the moisture invariants (#158), the sanitizer job (#180), the HTTP characterisation tests (#174), the threading reproduction (#176),runANN(#183), and the double-free and shared-state fixes (#157, #177, #178).The two files differ by additions only — 45 entry lines and 10 link definitions, zero removals:
So when
devis next merged intomaster, this file supersedes that one with nothing to resolve. That is why the[Unreleased]heading text is identical on both branches rather than each describing its own branch — a one-line difference there would have conflicted on every sync.Two things our own work made stale
FOREFIRE_BUILD_TESTS,FOREFIRE_ENABLE_WARNINGS,FOREFIRE_WARNINGS_AS_ERRORSandFOREFIRE_SANITIZE. The "wheel builds flip these" sentence now mentions tools and tests too, which those builds also turn off.CONTRIBUTING.mdsaid to verify withcd tests && bash run.bash. That does not reach the C++ unit tests at all — they are a CTest suite. Both commands are listed now. This is the correction Add a CHANGELOG #184 deliberately left out: onmasterthe script-driven suites still fail onrunANN, so there was nothing accurate to write there until Make runANN work, and run it in CI #183 arrived.Verification
[#nnn]without a definition, no duplicate definitions.This pull request, including its code changes and this description, was generated by Claude Opus 5, and reviewed manually before submitting.