feat(security): let a caller pass cargo-deny arguments - #58
Merged
Conversation
Fourteen repos carry a private security.yml instead of calling this reusable -- the largest single drift class in the fleet. Most of it is stale copy-drift, but one difference could not be expressed here at all: four repos (akroasis, epitelesis, logismos, politeia) pass `--all-features` to cargo-deny, and this workflow passed only `command:`. Adopting the reusable would therefore have silently narrowed those four repos' dependency scan to default-features-only resolution. A security check that quietly covers less than it used to is the worst direction for one to move in, and nothing would have reported it. Absent this input the only choices were to keep four private copies or to regress them without noticing. Default is empty, which is cargo-deny's own behaviour and exactly what every current caller gets today, so no existing consumer changes. Verified rather than taken on report: an analysis pass claimed 13 of 14 repos passed --all-features. Reading the `arguments:` key in all fourteen files shows 4. The other nine mention the flag elsewhere in the file, against a different tool. The gap is real and narrower than reported.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Fourteen repos carry a private
.github/workflows/security.ymlinstead of calling this reusable —the largest single drift class in the fleet (kanon#3688). Most of it is stale copy-drift, but one
difference could not be expressed here at all: four repos pass
--all-featuresto cargo-deny,and this workflow passed only
command:.Evidence
Read from the
arguments:key in all fourteen local files:--all-featuresto cargo-denyThis reusable's cargo-deny step today:
No
arguments:.Why this matters
Adopting the reusable would have silently narrowed those four repos' dependency scan to
default-features-only resolution. A security check that quietly covers less than it used to is
the worst direction for one to move in, and nothing would have reported it — cargo-deny would
pass, faster, having examined fewer dependencies.
Absent this input the only choices were to keep four private copies forever, or to regress them
without noticing. That is the under-parameterisation making a whole drift class unresolvable, not
the copies themselves.
Desired correction
One optional input, defaulting to empty — which is cargo-deny's own behaviour and exactly what
every current caller gets today. No existing consumer changes.
Done when: akroasis, epitelesis, logismos and politeia can call this reusable without losing
all-features resolution.
A correction worth recording
An analysis pass reported that 13 of 14 repos passed
--all-features, which would have madethis urgent and fleet-wide. Re-deriving it from the
arguments:key in all fourteen files gives4. The other nine mention the flag elsewhere in the file, against a different tool.
The gap is real, and it is narrower than reported. The fix is the same either way; the priority is
not.
CI note
GitHub Actions is in a major outage (incident opened 2026-08-26T15:11:58Z). Checks here may queue,
startup_failure, or never be created. Nothing red before that closes is evidence about thischange, and I am not merging it on an empty rollup.