docs: record which checks are required on main, and why no path filter - #62
Merged
Conversation
This repository authors the reusables eleven repos inherit and until today required ZERO status checks to merge -- one approving review was the entire control. #59 removed the `paths:` filter from actionlint.yml so both guards run on every PR, which is the precondition for requiring them. The warning is the part worth writing down. The filter was not arbitrary: it existed so the workflow only ran when workflows or scripts changed. Removing it is what makes the checks eligible to be required, and reintroducing one would make every PR touching neither path unmergeable -- nothing failing, nothing pending, nothing to point at. That failure has already happened to a sibling repo's main, so the constraint is recorded here rather than left to be rediscovered. This file touches neither `.github/workflows/**` nor `scripts/**`, which makes it the probe: if both checks report on this PR, the filter drop is demonstrated rather than assumed, and the required contexts can be set on that evidence.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
forkwright/.githubrequired zero status checks to merge. The repository authoring thereusables eleven repos inherit had one approving review as its entire merge control.
Evidence
Observed consequence:
#57and#58both reportedmergeStateStatus: CLEANwith an emptystatusCheckRollup— CLEAN because nothing was blocking, not because anything passed.Why this PR exists, and what it is for
#59removed thepaths:filter fromactionlint.ymlsoactionlintandevent-shape-guardsrun on every PR. That is the precondition for making them required — a required check that cannot
run on some PRs blocks those PRs permanently.
This PR is the probe for that. It touches only
README.md— neither.github/workflows/**norscripts/**, the two paths the old filter named. If both checks report here, the filter drop isdemonstrated rather than assumed, and the required contexts can be set on that evidence.
#60could not serve: it touchedscripts/render_readme_tables.py, so it would have run under theold filter either way.
Desired correction
Record which checks are required and why the trigger must stay unfiltered. The warning is the
load-bearing half — the filter was not arbitrary, and someone restoring it for the obvious reason
("why lint workflows on a docs PR?") would make every PR touching neither path unmergeable. That
has already happened to a sibling repo's
main, so the constraint is written down rather than leftto be rediscovered.
Done when: both checks appear on this PR,
required_status_checksonmainnames them, andthis PR merges through the protection it documents.
Note
Deliberately not in scope:
enforce_adminsstaysfalse. Raising it removes the--adminpaththat is currently the only way to land in a private fleet repo during the account's Actions billing
lockout. A hold with a reason, revisitable once minutes return.