Skip to content

fix(ci): resolve cargo-deny + MSRV + binary smoke failures#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forkwright merged 2 commits into from
Apr 19, 2026
Merged

fix(ci): resolve cargo-deny + MSRV + binary smoke failures #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a00a58
fix(toml): expand multi-line inline tables to named blocks
Apr 19, 2026
895f8fb
fix(ci): remove broken binary smoke test job
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,19 +82,6 @@ jobs:
- name: Build docs
run: cargo doc --workspace --no-deps

# WHY: Binary builds and runs correctly with default features.
# Catches link errors and missing runtime deps.
smoke:
name: Binary smoke test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@631a55b12751854ce901bb631d5902ceb48146f7 # stable
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
# PROJECT: replace BINARY_CRATE and BINARY_NAME with your project's values
- name: Build binary
run: cargo build --release -p BINARY_CRATE
- name: Verify binary runs
run: ./target/release/BINARY_NAME --version || ./target/release/BINARY_NAME --help || true
# NOTE: No "Binary smoke test" job — hamma is a library-only workspace
# (dictyon + hamma-core, no [[bin]] targets). Reintroduce when a CLI/daemon
# crate is added, pinning BINARY_CRATE/BINARY_NAME to real values.
54 changes: 31 additions & 23 deletions Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,31 +45,9 @@ disallowed_types = "deny"
snafu = "0.8"

# TLS
rustls = {
version = "0.23",
default-features = false,
features = ["logging", "ring", "tls12"],
}
tokio-rustls = { version = "0.26", default-features = false }
webpki-roots = "1"

# Serialization
serde = { version = "1", default-features = false, features = [
"derive",
"std",
] }
serde_json = { version = "1", default-features = false, features = ["std"] }

# Async runtime
tokio = { version = "1", default-features = false, features = [
"rt-multi-thread",
"macros",
"net",
"time",
"sync",
"io-util",
] }

# Tracing
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
Expand All@@ -93,10 +71,40 @@ proptest = "1"
# Local workspace crates
hamma-core = { path = "crates/hamma-core", version = "0.1.0" }

# Expanded forms (inline table exceeded 80 columns; MSRV 1.85 predates TOML 1.1
# multi-line inline tables, so use [workspace.dependencies.X] blocks instead).

[workspace.dependencies.rustls]
version = "0.23"
default-features = false
features = ["logging", "ring", "tls12"]

[workspace.dependencies.serde]
version = "1"
default-features = false
features = ["derive", "std"]

[workspace.dependencies.serde_json]
version = "1"
default-features = false
features = ["std"]

[workspace.dependencies.tokio]
version = "1"
default-features = false
features = [
"rt-multi-thread",
"macros",
"net",
"time",
"sync",
"io-util",
]

[profile.dev.package."*"]
opt-level = 2

[profile.release]
lto = "thin"
codegen-units = 1
strip = true
strip = true
Loading