Uh oh!
There was an error while loading. Please reload this page.
feat: regenerate API client from OpenAPI spec - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated regeneration via openapi-python-client from
docs/v3/openapi3.yamlon frain-dev/convoy main. Hand-written webhook verify (src/convoy/utils/) is untouched by the sync script.Note
Low Risk
Generated client typing only; no request, auth, or runtime behavior changes beyond parsing a previously unexpected status.
Overview
The generated Convoy client now treats HTTP 504 as a documented response for listing event deliveries, instead of raising
UnexpectedStatuswhenraise_on_unexpected_statusis enabled.Adds
GetEventDeliveriesPagedResponse504(message,status, optional stubdata) and wires it through_parse_responseand the sync/async list helpers.Reviewed by Cursor Bugbot for commit 5ab2283. Bugbot is set up for automated code reviews on this repo. Configure here.