Skip to content

Stop ~100 lines of CMD 1802 returned error -19 on every R4 Pro boot#201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meehien wants to merge 1 commit into from
Closed

Stop ~100 lines of CMD 1802 returned error -19 on every R4 Pro boot #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions drivers/net/dsa/mxl862xx/mxl862xx-host.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,8 @@ int mxl862xx_api_wrap(struct mxl862xx_priv *priv, u16 cmd, void *data, u16 size,

#define MXL862XX_API_WRITE(dev, cmd, data) \
mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), false, false)
#define MXL862XX_API_WRITE_QUIET(dev, cmd, data) \
mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), false, true)
#define MXL862XX_API_READ(dev, cmd, data) \
mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), true, false)
#define MXL862XX_API_READ_QUIET(dev, cmd, data) \
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/dsa/mxl862xx/mxl862xx.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -248,7 +248,7 @@ static int mxl862xx_phy_read_mmd(struct mxl862xx_priv *priv, int addr,
};
int ret;

ret = MXL862XX_API_READ(priv, INT_GPHY_READ, param);
ret = MXL862XX_API_READ_QUIET(priv, INT_GPHY_READ, param);
if (ret)
return ret;

Expand All@@ -265,7 +265,7 @@ static int mxl862xx_phy_write_mmd(struct mxl862xx_priv *priv, int addr,
.data = cpu_to_le16(data),
};

return MXL862XX_API_WRITE(priv, INT_GPHY_WRITE, param);
return MXL862XX_API_WRITE_QUIET(priv, INT_GPHY_WRITE, param);
}

static int mxl862xx_phy_read_mii_bus(struct mii_bus *bus, int addr, int regnum)
Expand Down